move curriculum UI tests onto modular courses#66462
Conversation
800a202 to
83e39b8
Compare
86e01ae to
c84bdc0
Compare
b080bba to
d628a78
Compare
alex-m-brown
left a comment
There was a problem hiding this comment.
LGTM, just had a question. Should allthemigratedthings be completely removed if it's being replaced?
There was a problem hiding this comment.
Should the descriptions for allthelessonplans match allthemigrated things? Not sure if it really matters unless it's in an eyes test.
allthemigratedthings:
title: All the Migrated Things
description_short: ''
description_student: Student overview of the unit.
description_teacher: Teacher overview of the unit.
version_title: '2020'There was a problem hiding this comment.
another great catch! it looks like these eyes tests will likely be affected:
- dashboard/test/ui/features/teacher_tools/lesson_show.feature
- dashboard/test/ui/features/teacher_tools/teacher_lesson_plan.feature
I think it's a good idea to have content here, so I've added back the descriptions but also made a couple of tweaks that will likely cause eyes diffs:
- keeping the new name "All The Lesson Plans"
- updating student and teacher descriptions to say "course" instead of "unit"
I also copied some more translations over to the unit, which I thought would have been copied over by clone_migrated_unit but were not. The only thing different from the original there is:
- new name "All The Lesson Plans"
There was a problem hiding this comment.
heads up @drizco (Tuesday DOTD) that there will be some expected eyes diffs in these two tests:
- dashboard/test/ui/features/teacher_tools/lesson_show.feature
- dashboard/test/ui/features/teacher_tools/teacher_lesson_plan.feature
@alex-m-brown is your question just whether to remove the translations from courses/en.yml? deletion of units is a slippery concept -- deleting the .script_json file won't cause the unit to be deleted from other environments (including production), so the translation strings could still get used even though the unit is gone, though that probably won't be a big problem for a test-only unit that was in beta. deleting the |
|
my question was both about removing the |
|
Nice catch! I thought I had deleted some of this but it appears I did not. Since deletions of units and unit groups do not get propagated to other environments, I've opted for unpublishing the course and removing the lesson content from the unit. |
starts https://codedotorg.atlassian.net/browse/TEACH-1970. also see:
The goal is to get more coverage of modularity functionality by moving existing unit test coverage to use modular courses. We anticipate that the most common failure mode for modular courses is for a link or user action to fall through to the original course rather than staying in the modular course.
This PR does the following:
allthettsthingsunit is still a part ofallthettsthingscourse, but is now owned by a neworiginal-allthettsthings-coursein_development, so that any anyone without levelbuilder permissions will immediately get ano_accesswarning on any script level page. For example: Chrome_teacher_tools_level_types_bubble_choice_output.html . Depends on Teach 1975/ensure in development units are not visible to signed out users #66459.allthemigratedthingsis renamed toallthelessonplansbecause seeding will fail if you try to update theoriginal_unit_groupof a unit that has resources or vocab. I usedclone_migrated_unitfor this step, so it looks like a move but is really a copy and a deletion.resolved UI test issues:
my-professional-learning page no longer showing self-paced PL courses
original-alltheselfpacedplthings-courseto be a pl course"Viewing As Instructor" text not showing up on PL courses
Testing story
Follow-up work