Skip to content

Teach-1865/modularity support in section progress#66214

Merged
alex-m-brown merged 16 commits into
stagingfrom
TEACH-1865/modularity-support-in-section-progress
Jul 18, 2025
Merged

Teach-1865/modularity support in section progress#66214
alex-m-brown merged 16 commits into
stagingfrom
TEACH-1865/modularity-support-in-section-progress

Conversation

@alex-m-brown

@alex-m-brown alex-m-brown commented May 30, 2025

Copy link
Copy Markdown
Contributor

Depends on #66364

Right now, the links on the progress page always defaults to the original course URL instead of the current course's URL. This PR updates the method to use the currently selected course instead.
Screenshot 2025-07-17 at 10 36 09 AM
Screenshot 2025-07-17 at 10 36 44 AM

Links

Jira: TEACH-1865

Testing story

Manually verified and updated unit/UI tests

@alex-m-brown alex-m-brown force-pushed the TEACH-1865/modularity-support-in-section-progress branch from 8ab1eca to c28e67c Compare June 6, 2025 15:38
@alex-m-brown alex-m-brown reopened this Jun 6, 2025
@alex-m-brown alex-m-brown force-pushed the TEACH-1865/modularity-support-in-section-progress branch from 52eed26 to f5cbab8 Compare July 8, 2025 15:52
@alex-m-brown alex-m-brown changed the base branch from staging to TEACH-1937/modular-unit-selector July 10, 2025 15:09
@alex-m-brown alex-m-brown changed the base branch from TEACH-1937/modular-unit-selector to staging July 10, 2025 15:09
@alex-m-brown alex-m-brown force-pushed the TEACH-1865/modularity-support-in-section-progress branch from 292b6df to 74c5211 Compare July 16, 2025 19:07
@alex-m-brown alex-m-brown marked this pull request as ready for review July 17, 2025 14:34
@alex-m-brown alex-m-brown changed the title Teach 1865/modularity support in section progress Teach-1865/modularity support in section progress Jul 17, 2025
@davidsbailey

Copy link
Copy Markdown
Member

Right now, the links on the progress page always defaults to the original course URL instead of the current course's URL. This PR updates the method to use the currently selected course instead.

sorry for the basic question, but what does "current" or "currently selected" course mean in this case? On the progress view in teacher dashboard, I do not see any course in the url, for example.

@alex-m-brown

Copy link
Copy Markdown
Contributor Author

sorry for the basic question, but what does "current" or "currently selected" course mean in this case? On the progress view in teacher dashboard, I do not see any course in the url, for example.

Currently selected is the course that is selected in the unit dropdown. When you select a lesson in the progress table, it brings you to that lesson page.

example.mov

Before this PR, it would always bring you to the original course.

Screen.Recording.2025-07-17.at.1.36.21.PM.mov

@davidsbailey davidsbailey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests! just a couple nits, otherwise looks good

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want to log courseId here too:

logToCloud.addPageAction(logToCloud.PageAction.LoadScriptProgressStarted, {
sectionId,
scriptId,
});

expect(getSelectedScriptDescription(state)).toEqual(null);
});
});
});

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave describe('getSelectedScriptDescription' outside of describe('getSelectedUnitName'?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, good catch. there were a couple of weird nesting things going on in this file and I must've missed this one. Thank you

@alex-m-brown alex-m-brown merged commit 9a17205 into staging Jul 18, 2025
6 checks passed
@alex-m-brown alex-m-brown deleted the TEACH-1865/modularity-support-in-section-progress branch July 18, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants