fix continue and submit button for modular courses#66155
Merged
alex-m-brown merged 12 commits intoMay 30, 2025
Merged
Conversation
…s-for-modular-courses
davidsbailey
approved these changes
May 30, 2025
davidsbailey
left a comment
Member
There was a problem hiding this comment.
looks good! just one nit
| "properties": { | ||
| "is_migrated": true | ||
| "is_migrated": true, | ||
| "version_year": "2017" |
Member
There was a problem hiding this comment.
probably best to remove the version_year, since this lives on the unit group now?
Contributor
Author
There was a problem hiding this comment.
ah yes, thank you for the catch on that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some levels in modular courses, the user is redirected to the original unit group instead of the current unit group. This PR fixes that by passing the current unit group through to the milestone API which returns the next level_path
Links
Testing story
Update and add tests to ensure that users are kept in the correct course when a milestone is completed.
Manually verified that the reported bugs are fixed locally:
unit 1, lesson 2, level 4
unit 1, lesson 4, level 4