Conversation
…o script instead and testing to upload the result in after_test instead so that test_script can fail.
Moved all projects into src. Renamed projects to common naming convention. Use artifacts output layout. Use file scoped namespace. Use real DataSet implementation in tests. Enabled StyleCop for all projects.
List of methods and their properties as a table
Use LocalName instead of Name to fix #682
Fix for lower case cell reference reading ("a1" vs "A1").
* Activesheet support added * Fix formatting; * More formatting fixes; * One more formatting fix; * Fixes #642: address code analysis issues; * Fixes #642: revert test file changes; * Fixes #642: include unit tests from original fork (not sure how they were missed). * Fix failing test; Address style issues; --------- Co-authored-by: asheinkin <alexey.sheinkin@gmail.com> Co-authored-by: John Opincar <john.opincar@blackline.com>
…andard 2.1 and net 8.0 targets. Before: | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |------------------- |---------:|---------:|---------:|----------:|----------:|---------:|----------:| | ReadSingleFileXslx | 76.74 ms | 0.964 ms | 0.902 ms | 3500.0000 | - | - | 37.88 MB | | ReadSingleFileXslb | 16.71 ms | 0.160 ms | 0.149 ms | 2031.2500 | 93.7500 | - | 20.37 MB | | ReadSingleFileXls | 18.54 ms | 0.268 ms | 0.251 ms | 4187.5000 | 1312.5000 | 906.2500 | 42.74 MB | | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |------------------- |----------:|----------:|----------:|----------:|---------:|---------:|----------:| | OpenSingleFileXslx | 35.689 ms | 0.3813 ms | 0.3566 ms | 1500.0000 | 71.4286 | - | 15.38 MB | | OpenSingleFileXslb | 6.197 ms | 0.0668 ms | 0.0592 ms | 656.2500 | 31.2500 | - | 6.56 MB | | OpenSingleFileXls | 7.859 ms | 0.0444 ms | 0.0370 ms | 1312.5000 | 437.5000 | 218.7500 | 13.49 MB | After: | Method | Mean | Error | StdDev | Median | Gen0 | Gen1 | Gen2 | Allocated | |------------------- |---------:|---------:|----------:|---------:|----------:|---------:|---------:|----------:| | ReadSingleFileXslx | 65.42 ms | 5.479 ms | 16.156 ms | 55.16 ms | 2700.0000 | 200.0000 | - | 27.13 MB | | ReadSingleFileXslb | 13.41 ms | 0.034 ms | 0.032 ms | 13.41 ms | 1484.3750 | 62.5000 | - | 14.95 MB | | ReadSingleFileXls | 16.91 ms | 0.068 ms | 0.063 ms | 16.90 ms | 2750.0000 | 968.7500 | 656.2500 | 28.32 MB | | Method | Mean | Error | StdDev | Gen0 | Gen1 | Gen2 | Allocated | |------------------- |----------:|----------:|----------:|---------:|---------:|---------:|----------:| | OpenSingleFileXslx | 20.001 ms | 0.3678 ms | 0.3440 ms | 750.0000 | 62.5000 | - | 7.75 MB | | OpenSingleFileXslb | 4.860 ms | 0.0154 ms | 0.0137 ms | 421.8750 | 23.4375 | - | 4.27 MB | | OpenSingleFileXls | 6.282 ms | 0.0290 ms | 0.0271 ms | 656.2500 | 328.1250 | 218.7500 | 5.91 MB |
Fixes issue #574
* Added exception handling for invalid iso timespan * Add tests --------- Co-authored-by: Johan Appelgren <johan.appelgren@gmail.com>
…ypted .xlsx .NET 8.0.16 Before: | Method | Mean | Error | StdDev | Gen0 | Allocated | |------- |---------:|---------:|---------:|----------:|----------:| | Xlsx | 49.71 ms | 0.849 ms | 0.795 ms | 3636.3636 | 66.28 MB | After: | Method | Mean | Error | StdDev | Allocated | |------- |---------:|---------:|---------:|----------:| | Xlsx | 35.81 ms | 0.150 ms | 0.140 ms | 677.72 KB |
* Added tests * Removed usage of custom height * Used absolute value of parsed default and row height * Minor refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.