Skip to content

Issue #642: Active Tab/Sheet Support#685

Merged
appel1 merged 8 commits into
ExcelDataReader:developfrom
john-blackline:develop
Aug 27, 2024
Merged

Issue #642: Active Tab/Sheet Support#685
appel1 merged 8 commits into
ExcelDataReader:developfrom
john-blackline:develop

Conversation

@john-blackline

@john-blackline john-blackline commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Submitting cherry pick of active sheet support added by asheinken here with style/analysis/formatting changes as needed for current state of code.

This is for issue #642.

Note that we are successfully running the changes in this PR via a project in a solution and we'd love to go back to using the official nuget package.

@appel1

appel1 commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

Looks good, but could you revert the changes to the unrelated .xls test data files and write test cases for the added files?

@john-blackline

Copy link
Copy Markdown
Contributor Author

@appel1 , Done.

@appel1 appel1 merged commit ff08df0 into ExcelDataReader:develop Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants