Skip to content

Add CustomQuoteCharacter for reading csv files#689

Merged
appel1 merged 1 commit into
ExcelDataReader:developfrom
christopherGdynia:add-csv-custom-quote-character
Oct 15, 2024
Merged

Add CustomQuoteCharacter for reading csv files#689
appel1 merged 1 commit into
ExcelDataReader:developfrom
christopherGdynia:add-csv-custom-quote-character

Conversation

@christopherGdynia

@christopherGdynia christopherGdynia commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Hello all,

My name is Christopher, and we have been using your package in production for a couple of years now. I would like to thank you all for this excellent library—my colleagues and I really appreciate your work.

Initially, we thought the project wasn't being maintained anymore, which is why this pull request is coming so late.

We encountered an issue with one file import, where the file uses a custom quote character. We added support for this over a year ago, and it's been working well since then. 😀

I’ve noticed that this might resolve issue #580: "Cannot configure QuoteChar."

We would appreciate it if this could be included in a new version so that we no longer need to rely on a cloned repository.

If you need any changes or further assistance, please feel free to ask—I'd be happy to help!

Kind regards,
Christopher

(Edit)

After some checks, I remembered our specific problem: the CSV contained irregular fields with random quote characters, and additional quotes appeared randomly in subsequent rows and cells, which disrupted the CSV reading.

@christopherGdynia christopherGdynia force-pushed the add-csv-custom-quote-character branch 3 times, most recently from 4c5b95e to 617031e Compare October 14, 2024 11:59
@christopherGdynia christopherGdynia force-pushed the add-csv-custom-quote-character branch from 617031e to c6252be Compare October 14, 2024 12:27
@appel1 appel1 merged commit eab4b05 into ExcelDataReader:develop Oct 15, 2024
@appel1

appel1 commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

Looks good, thank you!

@christopherGdynia

Copy link
Copy Markdown
Contributor Author

@appel1 when can we expect a release on nuget? :)

@christopherGdynia christopherGdynia deleted the add-csv-custom-quote-character branch October 16, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants