Issue 694: Fix timespan parsing for invalid iso values#705
Merged
appel1 merged 3 commits intoMay 4, 2025
Merged
Conversation
Hasan-75
approved these changes
May 4, 2025
Collaborator
|
Seems I'm not very good with the web merge ui. Fixed in a later commit. :| |
This was referenced Sep 22, 2025
This was referenced Sep 29, 2025
This was referenced Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
In some cases, the cell is formatted as a timespan and the value is generated by a formula, but the result is not a valid timespan. In such situations,
XmlConvert.ToTimeSpanwill throw aFormatException. It is reasonable to handle these cases by catching the exception.Solution
Added excpetion handling for
FormatExceptionraised byXmlConvert.ToTimeSpan, and moved the related code to a new private method.