feat(compiler-cli): Adapt the compiler to use standalone by default. #58169
Closed
JeanMeche wants to merge 9 commits intoangular:mainfrom
Closed
feat(compiler-cli): Adapt the compiler to use standalone by default. #58169JeanMeche wants to merge 9 commits intoangular:mainfrom
JeanMeche wants to merge 9 commits intoangular:mainfrom
Conversation
480c7f9 to
408084f
Compare
408084f to
5c327a2
Compare
4c1af50 to
2d8b834
Compare
2d8b834 to
d225472
Compare
With this commit directives, components & pipes are standalone by default. To be declared in an `NgModule`, those require now `standalone: false`.
Use `semver` in the partial compiler to decide on a default value Co-authored-by: Alex Rickabaugh <alxhub@users.noreply.github.com>
`UpgradeComponent` is meant to be used as a subclass, it doesn't need to disable `standalone`.
After flipping the standalone default value, this is reflected in the partial output result.
… default This commit is part of the migration to standalone by default.
With this commit, the standalone migration will only migrate code with `standalone: false` to standalone by default (without the standalone attribute)
alxhub
reviewed
Oct 14, 2024
| ); | ||
| } | ||
|
|
||
| const STANDALONE_IS_DEFAULT_RANGE = new semver.Range('>= 19.0.0', { |
Member
There was a problem hiding this comment.
We should make sure that 0.0.0-PLACEHOLDER is also considered to pass.
alxhub
approved these changes
Oct 14, 2024
devversion
approved these changes
Oct 15, 2024
packages/compiler/src/util.ts
Outdated
| } | ||
|
|
||
| const SINGLE_DIGIT_VERSIONS = /^\d\./; | ||
| const V11_V18 = /1[12345678]\./; |
Member
There was a problem hiding this comment.
Nit: Could probably combine this into a single Regex. e.g. V1_TO_18 = ^([1-9]|1[0-8])\.
Member
Author
|
This change has currently an issue in our compliance tests. Edit: fixed |
jelbourn
approved these changes
Oct 15, 2024
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
Contributor
|
Caretaker note: presubmit failure looks like a flake to me; I ran a TGP for these changes yesterday and it was green |
Member
|
This PR was merged into the repository by commit 9ab663e. The changes were merged into the following branches: main |
This was referenced Oct 15, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #58160 & #58175
This PR flips the default for standalone from
falsetotruefor components, directives and pipes.This PR also includes the necessary changes for the impacted tests as well as other targets that dependens on them (adev, benchmarks etc).