fix(@schematics/angular): explicitly set standalone:false#28642
Merged
hybrist merged 2 commits intoangular:mainfrom Oct 16, 2024
Merged
fix(@schematics/angular): explicitly set standalone:false#28642hybrist merged 2 commits intoangular:mainfrom
hybrist merged 2 commits intoangular:mainfrom
Conversation
477dc8c to
cf33d0e
Compare
cf33d0e to
6f28309
Compare
Contributor
Author
|
Updated to apply the explicit |
alan-agius4
reviewed
Oct 15, 2024
tests/legacy-cli/e2e/tests/build/prerender/discover-routes-ngmodule.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Not: can you cherry-pick the commit from #28634 so that we ran the full snapshot suite in CI? |
6f28309 to
b1ff31c
Compare
Contributor
Author
|
Included the angular update commit in the PR again to ensure the post-upgrade state is tested. |
Contributor
Author
|
🍏 💚 🟢 ! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the new default for standalone is
true, any place that previously omitted the value to get an implicitfalsenow needs to set it tofalseexplicitly.See: angular/angular#58169