refactor(compiler-cli): Prepare the compiler to flip the default standalone value. #58175
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
refactor(compiler-cli): Prepare the compiler to flip the default standalone value. #58175JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
d93da1b to
884aabc
Compare
884aabc to
07f7ed5
Compare
07f7ed5 to
bb6cbd1
Compare
bb6cbd1 to
1dcb70e
Compare
1dcb70e to
89778bf
Compare
89778bf to
1d1047b
Compare
410c9ce to
f033387
Compare
jelbourn
approved these changes
Oct 14, 2024
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
This commit is part of the migration to standalone by default and sets up 2 files with a default value for standalone. They are still `false` in this case to land the change into G3 first. The switch to `true` will be executed in a follow-up PR.
f033387 to
a2dfee5
Compare
alxhub
approved these changes
Oct 14, 2024
Member
|
This PR was merged into the repository by commit 517da95. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #58160
This is mainly a refactor to prepare the repo to flip the change and ease the landing into G3.