refactor(compiler): dynamic default for the partial compiler.

Use `semver` in the partial compiler to decide on a default value Co-authored-by: Alex Rickabaugh <alxhub@users.noreply.github.com>
angular · JeanMeche · Oct 12, 2024 · Oct 12, 2024 · Oct 12, 2024 · Oct 12, 2024
commit 1380caaac70bdd64dd7b365b1a760c6360967166
diff --git a/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_component_linker_1.ts b/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_component_linker_1.ts
@@ -217,7 +217,7 @@ export class PartialComponentLinkerVersion1<TStatement, TExpression>
     }
 
     return {
-      ...toR3DirectiveMeta(metaObj, this.code, this.sourceUrl),
+      ...toR3DirectiveMeta(metaObj, this.code, this.sourceUrl, version),
       viewProviders: metaObj.has('viewProviders') ? metaObj.getOpaque('viewProviders') : null,
       template: {
         nodes: template.nodes,

diff --git a/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_directive_linker_1.ts b/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_directive_linker_1.ts
@@ -32,7 +32,7 @@ import {AstObject, AstValue} from '../../ast/ast_value';
 import {FatalLinkerError} from '../../fatal_linker_error';
 
 import {LinkedDefinition, PartialLinker} from './partial_linker';
-import {extractForwardRef, wrapReference} from './util';
+import {extractForwardRef, getDefaultStandaloneValue, wrapReference} from './util';
 
 /**
  * A `PartialLinker` that is designed to process `ɵɵngDeclareDirective()` call expressions.
@@ -46,8 +46,9 @@ export class PartialDirectiveLinkerVersion1<TExpression> implements PartialLinke
   linkPartialDeclaration(
     constantPool: ConstantPool,
     metaObj: AstObject<R3PartialDeclaration, TExpression>,
+    version: string,
   ): LinkedDefinition {
-    const meta = toR3DirectiveMeta(metaObj, this.code, this.sourceUrl);
+    const meta = toR3DirectiveMeta(metaObj, this.code, this.sourceUrl, version);
     return compileDirectiveFromMetadata(meta, constantPool, makeBindingParser());
   }
 }
@@ -59,6 +60,7 @@ export function toR3DirectiveMeta<TExpression>(
   metaObj: AstObject<R3DeclareDirectiveMetadata, TExpression>,
   code: string,
   sourceUrl: AbsoluteFsPath,
+  version: string,
 ): R3DirectiveMetadata {
   const typeExpr = metaObj.getValue('type');
   const typeName = typeExpr.getSymbolName();
@@ -96,7 +98,9 @@ export function toR3DirectiveMeta<TExpression>(
     },
     name: typeName,
     usesInheritance: metaObj.has('usesInheritance') ? metaObj.getBoolean('usesInheritance') : false,
-    isStandalone: metaObj.has('isStandalone') ? metaObj.getBoolean('isStandalone') : false,
+    isStandalone: metaObj.has('isStandalone')
+      ? metaObj.getBoolean('isStandalone')
+      : getDefaultStandaloneValue(version),
     isSignal: metaObj.has('isSignal') ? metaObj.getBoolean('isSignal') : false,
     hostDirectives: metaObj.has('hostDirectives')
       ? toHostDirectivesMetadata(metaObj.getValue('hostDirectives'))

diff --git a/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_pipe_linker_1.ts b/packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_pipe_linker_1.ts
@@ -18,7 +18,7 @@ import {AstObject} from '../../ast/ast_value';
 import {FatalLinkerError} from '../../fatal_linker_error';
 
 import {LinkedDefinition, PartialLinker} from './partial_linker';
-import {wrapReference} from './util';
+import {getDefaultStandaloneValue, wrapReference} from './util';
 
 /**
  * A `PartialLinker` that is designed to process `ɵɵngDeclarePipe()` call expressions.
@@ -29,8 +29,9 @@ export class PartialPipeLinkerVersion1<TExpression> implements PartialLinker<TEx
   linkPartialDeclaration(
     constantPool: ConstantPool,
     metaObj: AstObject<R3PartialDeclaration, TExpression>,
+    version: string,
   ): LinkedDefinition {
-    const meta = toR3PipeMeta(metaObj);
+    const meta = toR3PipeMeta(metaObj, version);
     return compilePipeFromMetadata(meta);
   }
 }
@@ -40,6 +41,7 @@ export class PartialPipeLinkerVersion1<TExpression> implements PartialLinker<TEx
  */
 export function toR3PipeMeta<TExpression>(
   metaObj: AstObject<R3DeclarePipeMetadata, TExpression>,
+  version: string,
 ): R3PipeMetadata {
   const typeExpr = metaObj.getValue('type');
   const typeName = typeExpr.getSymbolName();
@@ -51,7 +53,9 @@ export function toR3PipeMeta<TExpression>(
   }
 
   const pure = metaObj.has('pure') ? metaObj.getBoolean('pure') : true;
-  const isStandalone = metaObj.has('isStandalone') ? metaObj.getBoolean('isStandalone') : false;
+  const isStandalone = metaObj.has('isStandalone')
+    ? metaObj.getBoolean('isStandalone')
+    : getDefaultStandaloneValue(version);
 
   return {
     name: typeName,

diff --git a/packages/compiler-cli/linker/src/file_linker/partial_linkers/util.ts b/packages/compiler-cli/linker/src/file_linker/partial_linkers/util.ts
@@ -17,6 +17,7 @@ import {
 
 import {AstObject, AstValue} from '../../ast/ast_value';
 import {FatalLinkerError} from '../../fatal_linker_error';
+import semver from 'semver';
 
 export const PLACEHOLDER_VERSION = '0.0.0-PLACEHOLDER';
 
@@ -113,3 +114,11 @@ export function extractForwardRef<TExpression>(
     ForwardRefHandling.Unwrapped,
   );
 }
+
+const STANDALONE_IS_DEFAULT_RANGE = new semver.Range('>= 19.0.0', {
+  includePrerelease: true,
+});
+
+export function getDefaultStandaloneValue(version: string): boolean {
+  return STANDALONE_IS_DEFAULT_RANGE.test(version);
+}
diff --git a/packages/compiler-cli/src/ngtsc/metadata/src/dts.ts b/packages/compiler-cli/src/ngtsc/metadata/src/dts.ts
@@ -139,6 +139,8 @@ export class DtsMetadataReader implements MetadataReader {
     const ngContentSelectors =
       def.type.typeArguments.length > 6 ? readStringArrayType(def.type.typeArguments[6]) : null;
 
+    // Note: the default value is still `false` here, because only legacy .d.ts files written before
+    // we had so many arguments use this default.
     const isStandalone =
       def.type.typeArguments.length > 7 && (readBooleanType(def.type.typeArguments[7]) ?? false);
 

diff --git a/packages/compiler/src/compiler_facade_interface.ts b/packages/compiler/src/compiler_facade_interface.ts
@@ -227,6 +227,7 @@ export type LegacyInputPartialMapping =
 export interface R3DeclareDirectiveFacade {
   selector?: string;
   type: Type;
+  version: string;
   inputs?: {
     [fieldName: string]:
       | {
@@ -390,6 +391,7 @@ export interface R3DeclareNgModuleFacade {
 
 export interface R3DeclarePipeFacade {
   type: Type;
+  version: string;
   name: string;
   pure?: boolean;
   isStandalone?: boolean;

diff --git a/packages/compiler/src/jit_compiler_facade.ts b/packages/compiler/src/jit_compiler_facade.ts
@@ -105,6 +105,7 @@ import {makeBindingParser, parseTemplate} from './render3/view/template';
 import {ResourceLoader} from './resource_loader';
 import {DomElementSchemaRegistry} from './schema/dom_element_schema_registry';
 import {SelectorMatcher} from './selector';
+import {getJitStandaloneDefaultForVersion} from './util';
 
 export class CompilerFacadeImpl implements CompilerFacade {
   FactoryTarget = FactoryTarget;
@@ -567,7 +568,8 @@ function convertDeclareDirectiveFacadeToMetadata(
     deps: null,
     typeArgumentCount: 0,
     fullInheritance: false,
-    isStandalone: declaration.isStandalone ?? false,
+    isStandalone:
+      declaration.isStandalone ?? getJitStandaloneDefaultForVersion(declaration.version),
     isSignal: declaration.isSignal ?? false,
     hostDirectives,
   };
@@ -1018,7 +1020,8 @@ function convertDeclarePipeFacadeToMetadata(declaration: R3DeclarePipeFacade): R
     pipeName: declaration.name,
     deps: null,
     pure: declaration.pure ?? true,
-    isStandalone: declaration.isStandalone ?? false,
+    isStandalone:
+      declaration.isStandalone ?? getJitStandaloneDefaultForVersion(declaration.version),
   };
 }
 

diff --git a/packages/compiler/src/util.ts b/packages/compiler/src/util.ts
@@ -166,3 +166,20 @@ export function partitionArray<T, F = T>(
   }
   return [truthy, falsy];
 }
+
+const SINGLE_DIGIT_VERSIONS = /^\d\./;
+const V11_V18 = /1[12345678]\./;
+
+export function getJitStandaloneDefaultForVersion(version: string): boolean {
+  if (version.startsWith('0.')) {
+    // 0.0.0 is always "latest", default is true.
+    return true;
+  }
+  if (SINGLE_DIGIT_VERSIONS.test(version) || V11_V18.test(version)) {
+    // Angular v2 - v18 default is false.
+    return false;
+  }
+
+  // All other Angular versions (v19+) default to true.
+  return true;
+}
diff --git a/packages/core/src/compiler/compiler_facade_interface.ts b/packages/core/src/compiler/compiler_facade_interface.ts
@@ -227,6 +227,7 @@ export type LegacyInputPartialMapping =
 export interface R3DeclareDirectiveFacade {
   selector?: string;
   type: Type;
+  version: string;
   inputs?: {
     [fieldName: string]:
       | {
@@ -391,6 +392,7 @@ export interface R3DeclareNgModuleFacade {
 export interface R3DeclarePipeFacade {
   type: Type;
   name: string;
+  version: string;
   pure?: boolean;
   isStandalone?: boolean;
 }

diff --git a/packages/core/test/render3/ivy/jit_spec.ts b/packages/core/test/render3/ivy/jit_spec.ts
@@ -65,6 +65,7 @@ describe('render3 jit', () => {
     class OuterCmp {
       static ɵcmp = ngDeclareComponent({
         template: '<inner-cmp></inner-cmp>',
+        version: '18.0.0',
         type: OuterCmp,
         components: [
           {
@@ -95,6 +96,7 @@ describe('render3 jit', () => {
       static ɵcmp = ngDeclareComponent({
         template: '<inner-cmp></inner-cmp>',
         type: OuterCmp,
+        version: '18.0.0',
         dependencies: [
           {
             kind: 'component',