ROX-37157: add workload kind policy exclusion in wizard - #22964

@@            Coverage Diff             @@
##           master   #22964      +/-   ##
==========================================
- Coverage   52.01%   51.98%   -0.04%     
==========================================
  Files        2913     2913              
  Lines      183638   183638              
==========================================
- Hits        95526    95458      -68     
- Misses      79767    79814      +47     
- Partials     8345     8366      +21     

Flags with carried forward coverage won't be shown. Click here to find out more.

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

⚙️ Run configuration

• Configuration used: Central YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: b68b7acd-569a-422d-8494-3a51ff659b63

📥 Commits

Reviewing files that changed from the base of the PR and between 173caaa and 29e618e.

📒 Files selected for processing: 1

• ui/apps/platform/cypress/integration/policies/policyWizard.helpers.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Summary by CodeRabbit

• New Features
  • Policies can exclude CronJobs and Jobs by workload kind when the feature is enabled. Selected exclusions appear in policy details and remain available when editing and saving a policy.
• Improvements
  • Policy scope fields and details use “workload” and “workload label” terminology instead of “deployment” and “deployment label.”
  • Workload-kind exclusions are cleared when the selected event source or lifecycle stages do not support them, and are unavailable for unsupported policy configurations.

The policy wizard adds feature-flagged exclusions for CronJobs and Jobs. Policy conversion, lifecycle updates, validation, and detail views now include workload-kind exclusions. Scope labels use workload terminology, and Cypress coverage tests policy creation and updates.

Changes: Workload-kind policy exclusions

Layer / File(s)	Summary
Workload-kind policy data and conversion ui/apps/platform/src/types/policy.proto.ts, ui/apps/platform/src/Containers/Policies/policies.utils.ts, ui/apps/platform/src/Containers/Policies/policies.utils.test.ts	Policy types and conversion utilities represent workload-kind exclusions, preserve them for applicable lifecycle stages, and format labels and messages. Tests cover conversion, lifecycle updates, and formatting.
Wizard selection and validation ui/apps/platform/src/Containers/Policies/Wizard/Step2/PolicyBehaviorForm.tsx, ui/apps/platform/src/Containers/Policies/Wizard/Step4/*, ui/apps/platform/src/Containers/Policies/Wizard/policyValidationSchemas.ts, ui/apps/platform/src/Containers/Policies/Wizard/policyValidationSchemas.test.ts, ui/apps/platform/src/types/featureFlag.ts	The feature-flagged wizard adds workload-kind checkboxes and validates selected kinds. It disables or clears selections for specified event sources and lifecycle stages. Scope labels change to workload terminology.
Policy scope details ui/apps/platform/src/Containers/Policies/Detail/*	Policy details display excluded workload kinds alongside excluded deployments. Workload names and labels use workload terminology.
Cypress policy workflow ui/apps/platform/cypress/integration/policies/policyWizard.helpers.ts, ui/apps/platform/cypress/integration/policies/policyWorkloadKindExclusion.test.ts	Cypress coverage creates a policy with CronJobs and a named workload exclusion, then reopens it, adds Jobs, and checks the displayed and saved scope.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant PolicyScopeForm
  participant policiesUtils
  participant ServerPolicy
  User->>PolicyScopeForm: Select workload kinds
  PolicyScopeForm->>policiesUtils: Provide excludedWorkloadKinds
  policiesUtils->>ServerPolicy: Serialize as excludeByKind
  ServerPolicy->>policiesUtils: Return saved exclusion
  policiesUtils->>PolicyScopeForm: Populate excludedWorkloadKinds

Loading

Suggested reviewers: bradr5

The changed Cypress selectors distinguish CronJobs from Jobs, and no concrete PR-specific behavior or test-workflow regression is established that prevents merging.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 17.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 35 functions across 19 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely identifies the main change: adding workload kind policy exclusions to the wizard.
Description check		The description covers the implementation, feature flag, user-facing behavior, testing, and validation. It retains a non-critical "change me!" placeholder and states that CI results were not inspected…

Full details: Description check

Explanation

The description covers the implementation, feature flag, user-facing behavior, testing, and validation. It retains a non-critical "change me!" placeholder and states that CI results were not inspected, but the required structure is otherwise mostly complete.

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR