Skip to content

fix(ui): use fixture data in podTimeline E2E tests - #21341

Merged
davdhacs merged 2 commits into
davdhacs/ui-e2efrom
davdhacs/fix-pod-timeline-fixtures
Jun 23, 2026
Merged

fix(ui): use fixture data in podTimeline E2E tests#21341
davdhacs merged 2 commits into
davdhacs/ui-e2efrom
davdhacs/fix-pod-timeline-fixtures

Conversation

@davdhacs

@davdhacs davdhacs commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Description

All 16 tests in podTimeline.test.js fail on GKE because openEventTimeline() calls viewGraph() without a fixture, so the deployment-level event timeline hits the live API. On a fresh cluster with no process events collected, the timeline renders empty and the drill-down button ([data-testid="timeline-drill-down-button"]) never appears.

Fix: pass deploymentEventTimeline.json fixture to openEventTimeline() in every test, matching the pattern used in deploymentTimeline.test.js (fixed in #21338). Also pass podEventTimeline.json to the Legend test's drill-down call for full fixture coverage.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • modified existing tests

How I validated my change

Same pattern as the deploymentTimeline.test.js fix in #21338 which is passing on GKE. The openEventTimeline() function now accepts and forwards a fixture path to viewGraph(), so the deployment-level GraphQL response is intercepted with fixture data instead of relying on live API data that doesn't exist on a fresh cluster.

@davdhacs @claude
fix(ui): use fixture data in podTimeline E2E tests
e1ac842 
All 16 tests in podTimeline.test.js fail on GKE because the
deployment-level event timeline renders empty (no process events
collected on a fresh cluster), so the drill-down button never
appears.

Pass deploymentEventTimeline.json fixture to openEventTimeline()
for every test, matching the pattern used in deploymentTimeline.test.js.
Also pass podEventTimeline.json fixture to the Legend test's
drill-down call for consistency.

AI-assisted change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5ae18d83-aad3-457e-954a-a86e7c1e2a6b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch davdhacs/fix-pod-timeline-fixtures

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davdhacs @claude
fix(ui): correct GCR integration test wait signal
87be932 
The previous fix waited for a deprecation notice alert that may not be
rendered in time. Wait for the IntegrationsTable "results found" h2
instead, which confirms the table component (and its button visibility
logic) has rendered.

AI-assisted change.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davdhacs
davdhacs merged commit 530e464 into davdhacs/ui-e2e Jun 23, 2026
63 of 65 checks passed
@davdhacs
davdhacs deleted the davdhacs/fix-pod-timeline-fixtures branch June 23, 2026 03:12
@github-actions

github-actions Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 87be932. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-546-g87be932172

davdhacs added a commit that referenced this pull request Jun 23, 2026
@davdhacs @claude
revert: remove test fixes from ui-e2e branch
9cce79a 
Test fixes belong in their own PRs (#21337, #21338, #21341) and
should not be merged into the ui-e2e workflow PR.

Partially generated by AI.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ai-assisted area/ui do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@davdhacs