Repository navigation
fix(test): use fixture data for timeline drill-down test - #21338
Conversation
The "drill down on a pod" test was the only test in deploymentTimeline that used real API data instead of fixture data. When the API returned empty pods (no process events collected yet), the test failed because the timeline list rendered without items — no amount of timeout increase would help since the data simply wasn't there. Switch to fixture data (deploymentEventTimeline.json for the deployment view, podEventTimeline.json for the pod drill-down), consistent with every other test in this file. This tests the UI navigation behavior (drill down shows pod name + back button) without depending on live cluster state. AI-assisted change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The GCR test asserts that the "New integration" button does not exist, but does so immediately after page visit without waiting for GCR-specific content to render. On GKE with higher latency, the page may not have fully settled before the assertion runs, causing a consistent failure. Wait for the GCR-specific deprecation notice alert before asserting the button's absence. AI-assisted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🚀 Build Images ReadyImages are ready for commit f71fc21. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-542-gf71fc21f91 |
Description
The deployment timeline drill-down test (
deploymentTimeline.test.js) was the only test in the file using real API data. When thegetDeploymentEventTimelinequery returned empty pods (no process events collected), the timeline rendered without list items. No timeout increase helps because the component renders from a single fetch with no polling.Switched to fixture data (
deploymentEventTimeline.json+podEventTimeline.json), consistent with every other test in this file. The test validates UI navigation behavior (drill down shows pod name + back button), not data availability.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Code review only. The fix applies the same fixture-based pattern used by all other tests in the file. The existing fixtures (
deploymentEventTimeline.json,podEventTimeline.json) contain valid pod/container data that exercises the drill-down navigation path.