Repository navigation
Conversation
The GCR test asserts that the "New integration" button does not exist, but does so immediately after page visit without waiting for GCR-specific content to render. On GKE with higher latency, the page may not have fully settled before the assertion runs, causing a consistent failure. Wait for the GCR-specific deprecation notice alert before asserting the button's absence. AI-assisted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Build Images ReadyImages are ready for commit cd5a7b0. To use with deploy scripts: export MAIN_IMAGE_TAG=4.12.x-591-gcd5a7b049f |
The previous fix waited for a deprecation notice alert that may not be rendered in time. Wait for the IntegrationsTable "results found" h2 instead, which confirms the table component (and its button visibility logic) has rendered. AI-assisted change. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/test gke-ui-e2e-tests |
|
@davdhacs: No presubmit jobs available for stackrox/stackrox@davdhacs/ui-e2e DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## davdhacs/ui-e2e #21337 +/- ##
===================================================
- Coverage 50.08% 50.08% -0.01%
===================================================
Files 2835 2835
Lines 217546 217546
===================================================
- Hits 108958 108950 -8
- Misses 100687 100695 +8
Partials 7901 7901
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Closing to trim active PR stack. Work preserved on branch — can reopen if needed. |
Description
The
integrations/imageIntegrations.testE2E test has a consistently failing assertion for the Google Container Registry (GCR) test case. The test assertscy.get('[data-testid="add-integration"]').should('not.exist')immediately aftervisitIntegrationsTablewithout waiting for GCR-specific content to render.On GKE with higher network latency, the page may not have fully settled before the assertion runs. The
<a>button element (rendered asa.pf-v6-c-button.pf-m-primary) is found in the DOM within the 8s timeout, causing consistent failure.The fix adds a preceding assertion that waits for the GCR-specific deprecation notice alert to appear before asserting the button's absence. This ensures the React component has rendered with the correct route props (
type='google',isCreationDisabled=true) before checking.User-facing documentation
Testing and quality
Automated testing
How I validated my change
The fix adds a gate assertion that waits for the GCR deprecation notice (
cy.get('.pf-v6-c-alert:contains("Deprecation notice")').should('exist')) before checking button absence. This is a standard Cypress pattern for ensuring page state before negative assertions. Will validate on the next GKE E2E run.