Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

add the useHTTPS checkbox to fix https/http support in Presto connection#997

Merged
dengc367 merged 3 commits into
sqlpad:masterfrom
dengc367:master
Apr 6, 2021
Merged

add the useHTTPS checkbox to fix https/http support in Presto connection#997
dengc367 merged 3 commits into
sqlpad:masterfrom
dengc367:master

Conversation

@dengc367

@dengc367 dengc367 commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

fix #995

@dengc367

dengc367 commented Apr 1, 2021

Copy link
Copy Markdown
Contributor Author

@rickbergfalk Please review this PR, Thanks.

Comment thread server/drivers/presto/index.js Outdated
rickbergfalk
rickbergfalk previously approved these changes Apr 2, 2021
@rickbergfalk

Copy link
Copy Markdown
Collaborator

@dengc367 sorry I just got caught up with things and saw other PR where http was previously hardcoded. I think this should be fine then. Might want to check the host string just to be safe, but probably not necessary.

Thanks for helping out on issues and other PR by the way! I've been busy with a new job :)

@dengc367

dengc367 commented Apr 3, 2021

Copy link
Copy Markdown
Contributor Author

ldap docker is error ?
image

@rickbergfalk

Copy link
Copy Markdown
Collaborator

The docker tests are flaky. I'll rerun them

@dengc367 dengc367 merged commit 1364996 into sqlpad:master Apr 6, 2021
pavel-slepenkov added a commit to pavel-slepenkov/sqlpad that referenced this pull request Apr 19, 2021
* master: (174 commits)
  v6.6.0
  Update dependencies (sqlpad#1002)
  add the useHTTPS checkbox to fix https/http support in Presto connection (sqlpad#997)
  Add support authentication for presto, allow https for presto (sqlpad#995)
  Fix clickhouse queries beginning with comment (sqlpad#991)
  v6.5.0
  Fix ClickHouse FORMAT JSON application and LIMIT syntax parsing (sqlpad#989)
  Fix package-lock.json files
  Update dependencies (with npm 6) (sqlpad#987)
  Add query run history viewer (sqlpad#986)
  add the *FORMAT JSON* clause to the query in order to fix the clickhouse library bug. (sqlpad#985)
  v6.4.3
  Set base during development only (sqlpad#983)
  v6.4.2
  Fix chart download button (sqlpad#981)
  v6.4.1
  Fix history modal padding (sqlpad#980)
  v6.4.0
  Add cell expanded value modal (sqlpad#979)
  Render connection name when hiding connection dropdown (sqlpad#977)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants