This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Add support authentication for presto, allow https for presto#995
Merged
Conversation
dengc367
approved these changes
Apr 1, 2021
Contributor
|
@maitrungduc1410 the Presto url need the http/https protocol. I add the checkbox to check http/https option in Presto connection form, and fix the Presto url bug. you can check and the test it. #997 |
Contributor
Author
|
@dengc367 , I think it doesn’t need, user takes responsibility to ensure the hostname is correct, and if any error during connection it already prints out and the user can know. This provide user flexibility when inputing db host |
pavel-slepenkov
added a commit
to pavel-slepenkov/sqlpad
that referenced
this pull request
Apr 19, 2021
* master: (174 commits) v6.6.0 Update dependencies (sqlpad#1002) add the useHTTPS checkbox to fix https/http support in Presto connection (sqlpad#997) Add support authentication for presto, allow https for presto (sqlpad#995) Fix clickhouse queries beginning with comment (sqlpad#991) v6.5.0 Fix ClickHouse FORMAT JSON application and LIMIT syntax parsing (sqlpad#989) Fix package-lock.json files Update dependencies (with npm 6) (sqlpad#987) Add query run history viewer (sqlpad#986) add the *FORMAT JSON* clause to the query in order to fix the clickhouse library bug. (sqlpad#985) v6.4.3 Set base during development only (sqlpad#983) v6.4.2 Fix chart download button (sqlpad#981) v6.4.1 Fix history modal padding (sqlpad#980) v6.4.0 Add cell expanded value modal (sqlpad#979) Render connection name when hiding connection dropdown (sqlpad#977) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httporhttpsfor Prestohost