This repository was archived by the owner on Aug 23, 2025. It is now read-only.
add the *FORMAT JSON* clause to the query in order to fix the clickho…#985
Merged
Conversation
rickbergfalk
approved these changes
Mar 15, 2021
rickbergfalk
left a comment
Collaborator
There was a problem hiding this comment.
I wish ClickHouse didn't require specifying format in the SQL query :/
Collaborator
|
@dengc367 Just thought of something - does this change work for non select statements like create/insert/update/delete? |
Contributor
Author
|
Yes, I test successfully with non select statements like create/insert/alter/delete. |
Collaborator
|
@dengc367 might need to roll this back. This is breaking queries for me using ClickHouse 20.8. Which version of ClickHouse are you using? |
Collaborator
|
It might just be with the ClickHouse test and the CREATE statements... |
Collaborator
|
Looks like issue is with |
pavel-slepenkov
added a commit
to pavel-slepenkov/sqlpad
that referenced
this pull request
Apr 19, 2021
* master: (174 commits) v6.6.0 Update dependencies (sqlpad#1002) add the useHTTPS checkbox to fix https/http support in Presto connection (sqlpad#997) Add support authentication for presto, allow https for presto (sqlpad#995) Fix clickhouse queries beginning with comment (sqlpad#991) v6.5.0 Fix ClickHouse FORMAT JSON application and LIMIT syntax parsing (sqlpad#989) Fix package-lock.json files Update dependencies (with npm 6) (sqlpad#987) Add query run history viewer (sqlpad#986) add the *FORMAT JSON* clause to the query in order to fix the clickhouse library bug. (sqlpad#985) v6.4.3 Set base during development only (sqlpad#983) v6.4.2 Fix chart download button (sqlpad#981) v6.4.1 Fix history modal padding (sqlpad#980) v6.4.0 Add cell expanded value modal (sqlpad#979) Render connection name when hiding connection dropdown (sqlpad#977) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…use library bug.
fix: #984