improvement(tests): converge env-flags mocks onto a complete shared mock by waleedlatif1 · Pull Request #5871 · simstudioai/sim

waleedlatif1 · 2026-07-23T00:13:31Z

Summary

Rewrite @sim/testing's env-flags mock as a COMPLETE, stateful module mock (all 37 flags + 5 functions; live accessors, setEnvFlags() / resetEnvFlagsMock() / envFlagsMockFns) and install it globally in vitest.setup — the old shared mock was itself missing 10 exports and had one wrong default
Migrate all 66 file-local vi.mock('@/lib/core/config/env-flags') factories onto it (partial factories were poisoning shared-worker runs: a suite crashed with 'No isHosted export is defined' from another file's partial mock); zero env-flags factories remain
Drop the repo's only bare vi.mock('mod') automock (drizzle-orm in knowledge search utils) — a bare automock colliding with factory mocks of the same module in a shared worker corrupts vitest's mock registry (reproduced in isolation; upstream Module mocking regression from Vitest 3 to Vitest 4 vitest-dev/vitest#10290 / #10145)
Phase 2 of the shared-worker campaign (db-mock convergence was improvement(testing): consolidate @sim/db mocks into one table-aware chain mock #5856 + improvement(tests): db-mock migration tranche 1 — knowledge, billing/org, workflows/background #5861/improvement(tests): db-mock migration tranche 2 — copilot, mothership, workspaces, connectors, mcp #5863/improvement(tests): db-mock migration tranche 3 — lib/workflows, lib/copilot remainder, ee/core/misc #5864/improvement(tests): db-mock migration tranche 4 — billing, webhooks/execution/logs, routes/misc (final) #5866)

Type of Change

Improvement

Testing

Full apps/sim suite green locally (13732/13733; sole failure is the known local ripgrep dependency, green in CI). All 66 migrated files re-verified together (1729/1729). tsc clean in apps/sim and packages/testing; biome clean.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

A bare vi.mock('drizzle-orm') automock colliding with factory mocks of the same module in a shared worker corrupts vitest's mock registry (upstream vitest-dev/vitest#10290 / #10145, reproduced in isolation). The global factory mock already covers this suite.

vercel · 2026-07-23T00:13:38Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 23, 2026 12:28am

cursor · 2026-07-23T00:13:42Z

PR Summary

Low Risk
Changes are limited to test mocks and setup; no runtime application paths are modified.

Overview
Test infrastructure only — production env-flags behavior is unchanged; this standardizes how suites stub deployment flags under Vitest’s shared worker.

Suites no longer define local vi.mock('@/lib/core/config/env-flags', …) factories (often incomplete, which leaked missing exports like isHosted across files). They import setEnvFlags, resetEnvFlagsMock, and sometimes envFlagsMockFns from @sim/testing, set flags in beforeEach / beforeAll, and reset in afterAll. Coverage spans API routes, billing, copilot, blocks, EE, rate limits, MCP, tables, and React component tests.

The shared mock is documented as a full stand-in for the real module (all flags plus helpers such as getCostMultiplier and getPreviewBlocksFromEnv), installed globally via vitest setup.

Also drops the only bare vi.mock('drizzle-orm') automock in knowledge search utils tests, which could corrupt Vitest’s mock registry when mixed with factory mocks in the same worker.

^{Reviewed by Cursor Bugbot for commit 718c7fe. Configure here.}

greptile-apps · 2026-07-23T00:16:26Z

Greptile Summary

This PR consolidates environment-flag mocks into one complete shared test module. The main changes are:

Adds stateful controls and live accessors for all environment flags.
Registers the shared mock globally in Vitest setup.
Migrates file-local factories to shared flag controls.
Removes the conflicting bare drizzle-orm automock.
Runs affected provider utility tests sequentially.

Confidence Score: 5/5

This looks safe to merge.

The shared mock covers the real module's flag and function exports.
The latest changes serialize tests that mutate shared flag state.
No blocking issue remains in the reviewed changes.

Important Files Changed

Filename	Overview
packages/testing/src/mocks/env-flags.mock.ts	Adds the complete stateful environment-flags mock and its mutation and reset helpers.
apps/sim/vitest.setup.ts	Registers the shared environment-flags mock for the full Vitest suite.
apps/sim/providers/utils.test.ts	Migrates provider tests to shared flag controls and serializes state-mutating cases.

_{Reviews (3): Last reviewed commit: "fix(tests): run providers/utils cases se..." | Re-trigger Greptile}

…uential setEnvFlags calls

waleedlatif1 · 2026-07-23T00:24:17Z

@greptile

waleedlatif1 · 2026-07-23T00:24:18Z

@cursor review

…ags state

waleedlatif1 · 2026-07-23T00:28:35Z

@greptile

waleedlatif1 · 2026-07-23T00:28:36Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 718c7fe. Configure here.}

waleedlatif1 added 2 commits July 22, 2026 17:09

improvement(tests): converge env-flags mocks onto a complete shared mock

c164afc

vercel Bot temporarily deployed to Preview July 23, 2026 00:13 Inactive

waleedlatif1 mentioned this pull request Jul 23, 2026

v0.7.42: event-driven discovery for MCP, nuqs adoption for deeplinks, test speedup, org session policies, proxy URL for API calls #5870

Merged

chore(tests): drop defensive resets in non-mutating suites, merge seq…

5b47f77

…uential setEnvFlags calls

vercel Bot temporarily deployed to Preview July 23, 2026 00:24 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/providers/utils.test.ts

fix(tests): run providers/utils cases sequentially over shared env-fl…

718c7fe

…ags state

vercel Bot temporarily deployed to Preview July 23, 2026 00:28 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

waleedlatif1 merged commit 9d8e14c into staging Jul 23, 2026
15 checks passed

waleedlatif1 deleted the test/env-flags-convergence2 branch July 23, 2026 00:31

waleedlatif1 mentioned this pull request Jul 23, 2026

improvement(tests+ci): phase 3 — shared-mock convergence completion and CI runner-minute cuts #5875

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

improvement(tests): converge env-flags mocks onto a complete shared mock#5871

improvement(tests): converge env-flags mocks onto a complete shared mock#5871
waleedlatif1 merged 4 commits into
stagingfrom
test/env-flags-convergence2

waleedlatif1 commented Jul 23, 2026

Uh oh!

vercel Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Jul 23, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 23, 2026 •

edited

Loading

cursor Bot commented Jul 23, 2026 •

edited

Loading

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading