Skip to content

improvement(tests): converge env-flags mocks onto a complete shared mock #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Jul 23, 2026
Merged

improvement(tests): converge env-flags mocks onto a complete shared mock #5871

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c164afc
improvement(tests): converge env-flags mocks onto a complete shared mock
waleedlatif1 Jul 23, 2026
2e4ba11
fix(tests): drop the repo's only bare vi.mock automock
waleedlatif1 Jul 23, 2026
5b47f77
chore(tests): drop defensive resets in non-mutating suites, merge seq…
waleedlatif1 Jul 23, 2026
718c7fe
fix(tests): run providers/utils cases sequentially over shared env-fl…
waleedlatif1 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tests): drop the repo's only bare vi.mock automock 
A bare vi.mock('drizzle-orm') automock colliding with factory mocks of the
same module in a shared worker corrupts vitest's mock registry (upstream
vitest-dev/vitest#10290 / #10145, reproduced in isolation). The global
factory mock already covers this suite.
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Jul 23, 2026
commit 2e4ba11bfd62830daad5b0577da4e5715585bb24
2 changes: 0 additions & 2 deletions apps/sim/app/api/knowledge/search/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { afterAll, afterEach, beforeEach, describe, expect, it, vi } from 'vites
import { env } from '@/lib/core/config/env'
import * as documentsUtilsModule from '@/lib/knowledge/documents/utils'

vi.mock('drizzle-orm')

/**
* Spy on the real documents/utils namespace instead of vi.mock: the shared
* `@/lib/knowledge/embeddings` module may be cached bound to the real module,
Expand Down
Loading