improvement(tests): db-mock migration tranche 2 — copilot, mothership, workspaces, connectors, mcp by waleedlatif1 · Pull Request #5863 · simstudioai/sim

waleedlatif1 · 2026-07-22T22:00:37Z

Summary

Migrate 26 test suites off private vi.mock('@sim/db', <factory>) implementations onto the shared dbChainMock + queueTableRows API — net ~−510 lines of bespoke chain plumbing (tranche 2 of the campaign; tranche 1 was improvement(tests): db-mock migration tranche 1 — knowledge, billing/org, workflows/background #5861, mock consolidation improvement(testing): consolidate @sim/db mocks into one table-aware chain mock #5856)
Clusters: app/api/copilot/** + lib/copilot/tools/handlers/**, app/api/mothership/**, app/api/workspaces/**, app/api/knowledge/[id]/connectors/**, app/api/mcp/** + lib/mcp/**
Additive schemaMock.copilotChats columns (pinned, deletedAt) matching the real schema
~70 private factories remain for later tranches

Type of Change

Improvement

Testing

Full apps/sim suite green locally (13704/13705; sole failure is the known local ripgrep dependency, green in CI). Every migrated file verified standalone, per-cluster in shared-worker runs, and with neighbor sweeps (copilot 1029 tests, knowledge/mcp 615, mothership/workspaces 119). tsc + biome clean.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…, workspaces, connectors, mcp

vercel · 2026-07-22T22:00:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 22, 2026 10:13pm

cursor · 2026-07-22T22:00:49Z

PR Summary

Low Risk
Test-only refactor and shared mock hardening; no production API or runtime behavior changes.

Overview
Second tranche of the DB mock migration: ~26 Vitest suites drop local vi.mock('@sim/db') chain factories and duplicate drizzle-orm stubs in favor of @sim/testing’s dbChainMock, dbChainMockFns, queueTableRows, and resetDbChainMock.

Tests now seed reads with queueTableRows(schemaMock.<table>, …), assert mutations via dbChainMockFns, and call resetDbChainMock() in beforeEach / afterAll so queued rows and …Once spy overrides do not leak across cases. Coverage spans copilot API routes and tool handlers, mothership chat routes, workspace API keys/BYOK/fork/invitations, knowledge connector routes, and MCP service/route tests.

In @sim/testing, resetDbChainMock resets all chain spies (including draining unconsumed mockResolvedValueOnce queues), adds notLike / notIlike to the drizzle mock, extends schemaMock.copilotChats with pinned and deletedAt, and adds a regression test for leftover …Once overrides.

^{Reviewed by Cursor Bugbot for commit 3f189f5. Configure here.}

greptile-apps · 2026-07-22T22:03:23Z

Greptile Summary

This PR moves 26 test suites to the shared database mock infrastructure. The main changes are:

Replaces private database factories with dbChainMock and table-aware row queues.
Resets shared mock state between tests and drains one-shot overrides.
Adds missing Copilot chat fields to the shared schema mock.
Preserves route and service coverage across Copilot, Mothership, workspaces, connectors, and MCP.

Confidence Score: 5/5

This looks safe to merge.

The updated reset clears queued rows and one-shot mock behavior.
The migrated tests preserve their main success, error, authorization, and cleanup paths.
No blocking issue tied to an eligible earlier review finding remains.

Important Files Changed

Filename	Overview
packages/testing/src/mocks/database.mock.ts	Resets all shared chain spies and adds the missing SQL operator mocks.
packages/testing/src/mocks/database.mock.test.ts	Adds a test proving reset removes unconsumed one-shot overrides.
packages/testing/src/mocks/schema.mock.ts	Adds `pinned` and `deletedAt` to the Copilot chat schema mock.
apps/sim/lib/mcp/service.test.ts	Migrates MCP service database behavior and status assertions to the shared mock.
apps/sim/app/api/mothership/chats/[chatId]/fork/route.test.ts	Migrates fork transaction, cleanup, and resource-rewrite coverage to the shared mock.
apps/sim/app/api/copilot/checkpoints/revert/route.test.ts	Uses table-aware queues for checkpoint and workflow lookups while retaining error coverage.

_{Reviews (2): Last reviewed commit: "fix(testing): drain unconsumed ...Once o..." | Re-trigger Greptile}

vi.clearAllMocks clears call history only — a ...Once override queued by a previous test but never consumed survived into the next test. resetDbChainMock now mockReset()s every shared spy and stable wrapper, which restores the original implementation AND drains once-queues.

waleedlatif1 · 2026-07-22T22:13:25Z

@greptile

waleedlatif1 · 2026-07-22T22:13:26Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 3f189f5. Configure here.}

improvement(tests): db-mock migration tranche 2 — copilot, mothership…

182f6d0

…, workspaces, connectors, mcp

vercel Bot temporarily deployed to Preview July 22, 2026 22:00 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread apps/sim/app/api/mcp/servers/[id]/refresh/route.test.ts

vercel Bot temporarily deployed to Preview July 22, 2026 22:13 Inactive

cursor Bot reviewed Jul 22, 2026

View reviewed changes

waleedlatif1 merged commit 52659d4 into staging Jul 22, 2026
20 checks passed

This was referenced Jul 22, 2026

improvement(tests): db-mock migration tranche 3 — lib/workflows, lib/copilot remainder, ee/core/misc #5864

Merged

improvement(tests): db-mock migration tranche 4 — billing, webhooks/execution/logs, routes/misc (final) #5866

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

improvement(tests): db-mock migration tranche 2 — copilot, mothership, workspaces, connectors, mcp#5863

improvement(tests): db-mock migration tranche 2 — copilot, mothership, workspaces, connectors, mcp#5863
waleedlatif1 merged 2 commits into
stagingfrom
test/db-mock-migration-2

waleedlatif1 commented Jul 22, 2026

Uh oh!

vercel Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Jul 22, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

waleedlatif1 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 22, 2026 •

edited

Loading

cursor Bot commented Jul 22, 2026 •

edited

Loading

greptile-apps Bot commented Jul 22, 2026 •

edited

Loading