Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sequelize/sequelize
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf53734
Choose a base ref
...
head repository: sequelize/sequelize
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d511d91
Choose a head ref
  • 20 commits
  • 28 files changed
  • 24 contributors

Commits on Oct 10, 2021

  1. fix(model): Convert number values only if they aren't null to avoid NaN 

    Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @caolvchong @sdepold
    caolvchong and sdepold authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    199b632 View commit details
    Browse the repository at this point in the history

  2. feat(typings): add UnknownConstraintError (#13461) 

    Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @atrick-speedline @sdepold
    atrick-speedline and sdepold authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    69d899e View commit details
    Browse the repository at this point in the history

  3. fix(model.d): accept [Op.is] in where (broken in TypeScript 4.4) (#13499 

    )

* fix(model.d): accept `[Op.is]` in where

* fix(model.d): test `[Op.is]` in where

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
    @zorji @sdepold @Keimeno
    3 people authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    d685a9a View commit details
    Browse the repository at this point in the history

  4. fix(types): add missing upsert hooks (#13394) 

    * Missing upsert hooks

Upsert hooks are missing in types

* fix(types): missing upsert hooks

Fixed upsert options type

* fix(types): missing upsert hooks

Just having a bad day

* fix(types): added tests for upsert hooks

* fix(types): incorrect attributes types for afterUpsert

Co-authored-by: Sergio Bernal <sergioguillot@gmail.com>
Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
    @reediculous456 @imsergiobernal @Keimeno
    3 people authored Oct 10, 2021
    Configuration menu
    Copy the full SHA
    5e9c209 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2021

  1. fix(types): extend BulkCreateOptions by SearchPathable (#13469) 

    add missing searchPath in BulkCreate.options:
    - extend BulkCreateOptions interface by SearchPathable to add missing searchPath option.
    - include searchPath in bulkCreate type test.

Closes #13454

Co-authored-by: Alexey Lyakhov <justfly1984@gmail.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @aryem @JustFly1984 @sdepold
    3 people authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    47c2d05 View commit details
    Browse the repository at this point in the history

  2. Update documentation - hooks.md - fixed snippet (#13441) 

    fixed code snippet which mixed `transaction` option with model fields.

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @SalehDehqanpour @sdepold
    SalehDehqanpour and sdepold authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    415989f View commit details
    Browse the repository at this point in the history

  3. refactor(*): add .gitattributes to force LF line ends (#13377) 

    Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @soryy708 @sdepold
    soryy708 and sdepold authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    8e98f47 View commit details
    Browse the repository at this point in the history

  4. Add sponsors badge

    @sdepold
    sdepold authored Oct 16, 2021
    Configuration menu
    Copy the full SHA
    dc67dc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. fix(sqlite): fix wrongly overwriting storage if empty string (#13376) 

    * fix(sqlite): fix wrongly overwriting storage if empty string

Empty string in SQLite3 means anonymous disk-based db, but sequelize overwrited it with :memory:

Closes #13375

* fix(sqlite): fix node<10 chokes on nullish coalescing operator

* refactor(sqlite): remove unnecessary parentheses around expression

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @soryy708 @sdepold
    soryy708 and sdepold authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    c3e608b View commit details
    Browse the repository at this point in the history

  2. refactor(connection-manager): change nullish coalescence implementati… 

    …on (#13568)
    @sdepold
    sdepold authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    e86c884 View commit details
    Browse the repository at this point in the history

  3. feat(postgres): support query_timeout dialect option (#13258) 

    * Add query_timeout option to postgres dialectOptions

* fix: lint issues in the test file

Co-authored-by: Kamalakannan Jayaraman <kamalakannan.j@brillio.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @sincerekamal @kamal-brill @sdepold
    3 people authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    3ca085d View commit details
    Browse the repository at this point in the history

  4. docs: add sqlcommenter-sequelize to the list of miscellaneous resourc… 

    …es (#13449)

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @jankleinert @sdepold
    jankleinert and sdepold authored Oct 17, 2021
    Configuration menu
    Copy the full SHA
    1340ea1 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. refactor(mssql test): Fix 'should not contain views' failing (#13400) 

    * fix(mssql): Fix 'should not contain views' failing

* Let's see if we can remove the try/catch statement

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @aboutml @sdepold
    aboutml and sdepold authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    176f4ff View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2021

  1. fix(types): typo in model.d.ts (#13574) 

    successfull -> successful
    @eltociear
    eltociear authored Oct 23, 2021
    Configuration menu
    Copy the full SHA
    31d0fbc View commit details
    Browse the repository at this point in the history

  2. fix(select): do not force set subQuery to false (#13490) 

    * fix(select): do not force set subQuery to false

this occurred on validating included elements in spite of user set it to true in include options

* test: make include (subQuery alias) tests dry

Co-authored-by: Victor Korzunin <victor.korzunin@blanco.services>
Co-authored-by: Constantin Metz <58604248+Keimeno@users.noreply.github.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @floydspace @Keimeno @sdepold
    4 people authored Oct 23, 2021
    Configuration menu
    Copy the full SHA
    0943339 View commit details
    Browse the repository at this point in the history

  3. fix(postgres): fix findCreateFind to work with postgres transactions ( 

    #13482)

* fix(postgres): fix `findCreateFind` to work with postgres transactions

* refactor(test): reduce complexity of test

* Update create.test.js

* Update create.test.js

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @Americas @sdepold
    Americas and sdepold authored Oct 23, 2021
    Configuration menu
    Copy the full SHA
    84421d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2021

  1. chore(probot-stale): reenable auto-close issues bot

    @fzn0x
    fzn0x authored Oct 24, 2021
    Configuration menu
    Copy the full SHA
    66e6d76 View commit details
    Browse the repository at this point in the history

  2. chore(docs): Add documentation for increment method (#13254) 

    * Add documentation for increment utility method

* Edit docs

Co-authored-by: drorh <dror.heller@nielsen.com>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @drorheller @drorHellerNielsen @sdepold
    3 people authored Oct 24, 2021
    Configuration menu
    Copy the full SHA
    4098eb0 View commit details
    Browse the repository at this point in the history

  3. fix: allows insert primary key with zero (#13458) 

    * fix: allows insert primary key with zero

* test: allows insert primary key with zero

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @zbinlin @sdepold
    zbinlin and sdepold authored Oct 24, 2021
    Configuration menu
    Copy the full SHA
    e4aff2f View commit details
    Browse the repository at this point in the history

  4. fix(types): allow any values in isIn validator (#12962) 

    * fix(types): allow any values in `isIn` validator

* test(types): isIn/notIn validation type tests

Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
    @lukashroch @sdepold
    lukashroch and sdepold authored Oct 24, 2021
    Configuration menu
    Copy the full SHA
    d511d91 View commit details
    Browse the repository at this point in the history
Loading