Skip to content

refactor(connection-manager): change nullish coalescence implementation#13568

Merged
sdepold merged 1 commit into
mainfrom
hotfix/refactor-13376
Oct 17, 2021
Merged

refactor(connection-manager): change nullish coalescence implementation#13568
sdepold merged 1 commit into
mainfrom
hotfix/refactor-13376

Conversation

@sdepold
Copy link
Copy Markdown
Member

@sdepold sdepold commented Oct 17, 2021

Follow-up to #13376

@sdepold
Copy link
Copy Markdown
Member Author

sdepold commented Oct 17, 2021

@soryy708 FYI :)

@sdepold sdepold merged commit e86c884 into main Oct 17, 2021
@sdepold sdepold deleted the hotfix/refactor-13376 branch October 17, 2021 11:57
@soryy708
Copy link
Copy Markdown
Contributor

@sdepold

if (!!this.sequelize.options.storage !== null && this.sequelize.options.storage !== undefined)

Why the !! at the beginning of the condition?
This turns this.sequelize.options.storage into a true or false which will never === null.
I expect the condition to be if (this.sequelize.options.storage !== null && this.sequelize.options.storage !== undefined)

@soryy708
Copy link
Copy Markdown
Contributor

@sdepold ?

@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants