fix(types): allow any values in isIn validator (#12962)

lukashroch · sdepold · web-flow · commit d511d9164e0f · 2021-10-24T13:39:35.000+02:00
* fix(types): allow any values in `isIn` validator

* test(types): isIn/notIn validation type tests

Co-authored-by: Sascha Depold &lt;sdepold@users.noreply.github.com&gt;
diff --git a/types/lib/model.d.ts b/types/lib/model.d.ts
@@ -1109,13 +1109,13 @@ export interface ModelValidateOptions {
   /**
    * check the value is not one of these
    */
-  notIn?: ReadonlyArray<readonly string[]> | { msg: string; args: ReadonlyArray<readonly string[]> };
+  notIn?: ReadonlyArray<readonly any[]> | { msg: string; args: ReadonlyArray<readonly any[]> };
 
   /**
    * check the value is one of these
    */
-  isIn?: ReadonlyArray<readonly string[]> | { msg: string; args: ReadonlyArray<readonly string[]> };
-
+  isIn?: ReadonlyArray<readonly any[]> | { msg: string; args: ReadonlyArray<readonly any[]> };
+  
   /**
    * don't allow specific substrings
    */
diff --git a/types/test/validators.ts b/types/test/validators.ts
@@ -0,0 +1,22 @@
+import { DataTypes, Model, Sequelize } from 'sequelize';
+
+const sequelize = new Sequelize('mysql://user:user@localhost:3306/mydb');
+
+/**
+ * Test for isIn/notIn validation - should accept any[]
+ */
+class ValidatedUser extends Model {}
+ValidatedUser.init({
+  name: {
+    type: DataTypes.STRING,
+    validate: {
+      isIn: [['first', 1, null]]
+    }
+  },
+  email: {
+    type: DataTypes.STRING,
+    validate: {
+      notIn: [['second', 2, null]]
+    }
+  },
+}, { sequelize });
