unwrap-unnecessary-dropdowns - Use segmented controls#9368
Draft
SunsetTechuila wants to merge 3 commits into
Draft
unwrap-unnecessary-dropdowns - Use segmented controls#9368SunsetTechuila wants to merge 3 commits into
unwrap-unnecessary-dropdowns - Use segmented controls#9368SunsetTechuila wants to merge 3 commits into
Conversation
Member
|
I bet they'll introduce a popup soon similar to what we have in the PR Files tab. Anyway, worth the change now since I suppose they won't be working on notifications before December. |
Member
|
Keep an eye on mobile too. I think our controls can appear on a single line so this would be improved already:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9204
Resolves #9203
Resolves #9202
Test URLs
https://github.com/notifications
Screenshot