Add threshold to codecov.yml#991
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 80.59% 80.58% -0.01%
==========================================
Files 138 138
Lines 14671 14671
==========================================
- Hits 11824 11823 -1
- Misses 2847 2848 +1
Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Sat 13 Mar 14:00 GMT (15:00 local). |
sroet
requested changes
Mar 12, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
LGTM, one minor change to actually set the patch threshold to 100%
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some recent PRs that should have no effect on coverage (#990, #984) have been getting complaints from CodeCov because a single line in netcdfplus has become uncovered (not sure if this is flakiness or a change in something upstream).
This PR adds a threshold so CodeCov will pass if flakiness uncovers up to 0.4% of the currently covered code. That corresponds to about 5 Python statements.
This only affects the CodeCov "project" check: the "patch" check will keep its default behavior, which is that coverage for lines changed in the PR must be at least as much as the current total project coverage.