[DO NOT MERGE] Test codecov patch#992
Conversation
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 80.59% 80.58% -0.01%
==========================================
Files 138 139 +1
Lines 14671 14674 +3
==========================================
+ Hits 11824 11825 +1
- Misses 2847 2849 +2
Continue to review full report at Codecov.
|
| @@ -0,0 +1 @@ | |||
| print("codecov should scream about this") | |||
There was a problem hiding this comment.
| print("codecov should scream about this") | |
| def fake_func(): | |
| print("codecov should scream about this") |
You need to import the file somewhere -- either in the main package or in a test_test.py test module. Coverage doesn't know about files unless they're imported (for example, none of the OPS visualization stuff is even included in unit tests, because it has to be imported separately.)
Also, check the .coveragerc to make sure that we don't exclude anything with "test" in it from coverage.
|
Py27 fail is something flaky with PyEMMA in recent days. CodeCov non-fail is because coverage.py doesn't see the file you added. |
Just the openpathsampling/tests/ directory, I did test if the coverage showed up in the coverage report if I ran |
|
Behaves as expected! 😄 |
|
Oh, although I should clarify: rule for patch is that it must increase total coverage, not have 100% coverage. |
Yeah, I was under the impression that you expected 100% coverage on any altered line. (unless, of course, explicitly untested with |
|
With that, this PR can be closed 😄 |
This is just a PR to make sure #991 does not alter the
patchcodecov requirements