SimStore: Periodic CVs#990
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 138 138
Lines 14671 14671
=======================================
Hits 11823 11823
Misses 2848 2848 Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Sun 14 Mar 19:00 GMT (20:00 local). |
sroet
approved these changes
Mar 14, 2021
sroet
left a comment
Member
There was a problem hiding this comment.
LGTM in general. I would like a slightly more specific test (just to make sure the error that you expect is raised). But please don't hang this PR on that.
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds information about periodicity to SimStore CVs. It reserves the kwargs
period_minandperiod_max.This isn't currently used anywhere in the core of OPS, but might be used in the future to combine
PeriodicCVDefinedVolumeandCVDefinedVolume(probably a good option for OPS 2.0).It will be used in the CLI for simulation setup.