build: pin envinfo versions in github actions#64117
Open
joyeecheung wants to merge 1 commit into
Open
Conversation
Currently they all run `npx envinfo` without pinning the version. This can be a supply-chain risk. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
|
Review requested:
|
Member
|
We should probably pin by commit hash to be safer |
Member
Author
You mean commit hash of envinfo? That's an npm package, pinning the version should be enough as npm does not allow republishing packages. Using the github clone will be slower with no significant benefit. |
Member
|
Yeah, different from GitHub Actions, npm tags are supposed to be immutable. |
RafaelGSS
approved these changes
Jun 24, 2026
targos
approved these changes
Jun 24, 2026
mertcanaltin
approved these changes
Jun 24, 2026
lpinca
approved these changes
Jun 24, 2026
marco-ippolito
approved these changes
Jun 24, 2026
marco-ippolito
left a comment
Member
There was a problem hiding this comment.
I thought it was an npm package, LGTM
panva
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently they all run
npx envinfowithout pinning the version. This can be a supply-chain risk.