stream: observe abort while awaiting pipeTo source#64015
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
cc8071c to
7d69188
Compare
Use the abort-aware iterator wrapper in the no-transform pipeTo() path so a pending source read does not block AbortSignal handling. Fixes: nodejs#64014 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
7d69188 to
e2918ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64014
stream/iter'spipeTo()already checks the abort signal after receivingsource batches, but the no-transform path did not observe aborts while waiting
for the next source chunk.
This updates that path to use the existing abort-aware iterator wrapper so
pipeTo()rejects promptly when the signal aborts, even if the sourcenext()call is still pending.Assisted-by: openai:gpt-5.5