child_process: fix permission model propagation via NODE_OPTIONS#63972
Open
mcollina wants to merge 1 commit into
Open
child_process: fix permission model propagation via NODE_OPTIONS#63972mcollina wants to merge 1 commit into
mcollina wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
The substring check env[key].indexOf(--permission) !== -1 in copyPermissionModelFlagsToEnv falsely treats unrelated NODE_OPTIONS values like --title=--permission as if the child already has an explicit Permission Model policy. This prevents flag propagation, causing the child to run without process.permission. Replace the substring check with proper token parsing that recognizes only actual --permission and --permission-audit flags. Add regression tests for --title=--permission, --conditions=--permission, --trace-event-categories=--permission, and --title=--permission-audit. Signed-off-by: Matteo Collina <hello@matteocollina.com>
32feff9 to
b0ebfb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in
copyPermissionModelFlagsToEnvwhere the substring checkenv[key].indexOf('--permission') !== -1falsely treats unrelatedNODE_OPTIONSvalues like--title=--permissionas if the child already has an explicit Permission Model policy. This prevents flag propagation, causing the child to run withoutprocess.permission.Fix
Replace the substring check with a helper
hasPermissionFlagInEnv()that tokenizesNODE_OPTIONSand checks for exact--permission/--permission-audittokens.Tests
Adds regression tests for:
NODE_OPTIONS=--title=--permissionNODE_OPTIONS=--conditions=--permissionNODE_OPTIONS=--trace-event-categories=--permissionNODE_OPTIONS=--title=--permission-audit