Update pre-commit hooks and CI tool versions#2376
Merged
adenzler-nvidia merged 5 commits intonewton-physics:mainfrom Apr 9, 2026
Merged
Update pre-commit hooks and CI tool versions#2376adenzler-nvidia merged 5 commits intonewton-physics:mainfrom
adenzler-nvidia merged 5 commits intonewton-physics:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (32)
✅ Files skipped from review due to trivial changes (28)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughBumps pinned Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.pre-commit-config.yaml (1)
20-34: Consider documenting tool updates in CHANGELOG if they result in code changes.The PR applies ruff-driven formatting fixes to the codebase. While tool version updates are typically internal changes, the resulting code formatting changes are visible to users and contributors.
As per coding guidelines, user-facing changes should include a CHANGELOG entry. If the formatting changes affect code that users interact with, consider adding an entry under the "Changed" category.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.pre-commit-config.yaml around lines 20 - 34, Add a CHANGELOG "Changed" entry noting the ruff-driven formatting and the tool/version updates shown in .pre-commit-config.yaml (ruff rev v0.15.9 with ruff-format, uv-pre-commit rev 0.11.4 with uv-lock, and typos rev v1.45.0) so users/contributors see that formatting changes were applied; include a brief line describing that code was auto-formatted by ruff and list the updated hook versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.pre-commit-config.yaml:
- Around line 20-34: Add a CHANGELOG "Changed" entry noting the ruff-driven
formatting and the tool/version updates shown in .pre-commit-config.yaml (ruff
rev v0.15.9 with ruff-format, uv-pre-commit rev 0.11.4 with uv-lock, and typos
rev v1.45.0) so users/contributors see that formatting changes were applied;
include a brief line describing that code was auto-formatted by ruff and list
the updated hook versions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: d207212f-eda3-41c0-9526-a9f2002d9b31
📒 Files selected for processing (24)
.github/workflows/aws_gpu_benchmarks.yml.github/workflows/aws_gpu_tests.yml.github/workflows/ci.yml.github/workflows/docs-dev.yml.github/workflows/docs-release.yml.github/workflows/minimum_deps_tests.yml.github/workflows/mujoco_warp_tests.yml.github/workflows/pr.yml.github/workflows/release.yml.github/workflows/scheduled_nightly.yml.github/workflows/warp_nightly_tests.yml.pre-commit-config.yamldocs/print_api.pynewton/_src/solvers/kamino/examples/newton/example_anymal_d.pynewton/_src/solvers/kamino/examples/newton/example_dr_legs.pynewton/_src/usd/utils.pynewton/_src/utils/selection.pynewton/examples/basic/example_basic_joints.pynewton/examples/basic/example_basic_shapes.pynewton/examples/robot/example_robot_anymal_d.pynewton/examples/robot/example_robot_cartpole.pynewton/examples/robot/example_robot_g1.pynewton/examples/selection/example_selection_cartpole.pypyproject.toml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@asv/benchmarks/benchmark_mujoco.py`:
- Around line 85-90: ROBOT_CONFIGS currently stores direct references to
_setup_kitchen and _setup_tabletop which are evaluated at import time and cause
NameError; change the config entries so setup_builder is a zero-arg callable
that defers lookup (e.g. wrap the references in lambdas) so that when code
retrieves config["setup_builder"] and calls it later the functions are resolved
at call time; update the entries for "kitchen" and "tabletop" in ROBOT_CONFIGS
accordingly while keeping the rest of the dict unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 9c8f088a-187a-40d0-b35f-51ee648d870d
📒 Files selected for processing (16)
asv/benchmarks/benchmark_mujoco.pynewton/_src/sim/graph_coloring.pynewton/_src/solvers/kamino/examples/newton/example_anymal_d.pynewton/_src/solvers/kamino/examples/newton/example_dr_legs.pynewton/_src/solvers/kamino/tests/test_solver_kamino.pynewton/examples/basic/example_basic_joints.pynewton/examples/basic/example_basic_shapes.pynewton/examples/robot/example_robot_anymal_d.pynewton/examples/robot/example_robot_cartpole.pynewton/examples/robot/example_robot_g1.pynewton/examples/selection/example_selection_cartpole.pynewton/tests/test_body_force.pynewton/tests/test_kinematic_links.pynewton/tests/test_rigid_contact.pynewton/tests/test_robot_composer.pynewton/tests/test_runtime_gravity.py
✅ Files skipped from review due to trivial changes (10)
- newton/_src/sim/graph_coloring.py
- newton/examples/basic/example_basic_shapes.py
- newton/_src/solvers/kamino/examples/newton/example_anymal_d.py
- newton/examples/robot/example_robot_anymal_d.py
- newton/examples/selection/example_selection_cartpole.py
- newton/examples/robot/example_robot_g1.py
- newton/_src/solvers/kamino/tests/test_solver_kamino.py
- newton/_src/solvers/kamino/examples/newton/example_dr_legs.py
- newton/examples/robot/example_robot_cartpole.py
- newton/examples/basic/example_basic_joints.py
Bump crate-ci/typos from v1.42.0 to v1.45.0 and add "iz" to the allowed words list in pyproject.toml to suppress a new false positive.
Bump ruff pre-commit hook from v0.14.10 to v0.15.9, uv pre-commit hook from 0.9.21 to 0.11.4, and uv version in all GitHub Actions workflows from 0.11.0 to 0.11.4.
Parenthesize multi-line lambda expressions and use rsplit() for last-component extraction, matching the updated ruff v0.15.9 rules.
Guard test_body_state() calls with # fmt: off so ruff does not parenthesize multi-line lambda bodies that Warp's create_warp_function re-parses via ast.parse (the parenthesized form triggers IndentationError at runtime). See NVIDIA/warp#1351. Also inline trivial pass-through lambdas flagged by the new PLW0108 rule.
The lambdas wrapping _setup_kitchen and _setup_tabletop are not trivial pass-throughs — they defer the name lookup past the module-level dict definition where the functions are not yet defined. Add noqa: PLW0108 to suppress the false positive.
06fac86 to
1cd2373
Compare
Kenny-Vilella
approved these changes
Apr 9, 2026
jsw7460
pushed a commit
to jsw7460/newton
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update pre-commit hooks and CI tool versions:
rsplitfor last-component extraction)izto typos allow-list to suppress new false positiveChecklist
CHANGELOG.mdhas been updated (if user-facing change)Test plan
Verify CI passes with updated tool versions.
Summary by CodeRabbit
Chores
Refactor