Update to the latest Notebook API#15416
Merged
Merged
Conversation
5c6fce1 to
a17dcd7
Compare
DonJayamanne
commented
Feb 16, 2021
| }, | ||
| "engines": { | ||
| "vscode": "^1.51.0" | ||
| "vscode": "^1.53.0" |
Author
There was a problem hiding this comment.
This is required else anyone falling into native notebooks xperiment might not have the latest VS Code version with support for native notebooks in jupyter extension.
DonJayamanne
commented
Feb 16, 2021
| public get onDidChangeActiveNotebookEditor(): Event<NotebookEditor | undefined> { | ||
| return this.canUseNotebookApi | ||
| ? this.notebook.onDidChangeActiveNotebookEditor | ||
| ? this.window.onDidChangeActiveNotebookEditor |
DonJayamanne
commented
Feb 16, 2021
| public get languageId(): string { | ||
| return this.notebook.languages[0]; | ||
| // eslint-disable-next-line global-require | ||
| const { NotebookCellKind } = require('vscode'); |
Author
There was a problem hiding this comment.
@rchiodo notebook documents no longer have a langauges property.
Hence this change.
jakebailey
reviewed
Feb 17, 2021
f7b3e4e to
1961aaf
Compare
DavidKutu
approved these changes
Feb 17, 2021
rchiodo
approved these changes
Feb 17, 2021
Member
|
@DonJayamanne is this going to get into the release? we still have a lot of users on 1.51 and 1.52 |
Author
This is going into insiders. |
|
@DonJayamanne We have some failing PR tests that are likely related to this https://github.com/microsoft/vscode-python/runs/1920019649. |
DonJayamanne
added a commit
that referenced
this pull request
Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #15415
Insiders tests will not pass until both extensions have been updated to use the new API.