Update to the latest Notebook API (#15416)#15602
Conversation
| "@types/untildify": "^3.0.0", | ||
| "@types/uuid": "^3.4.3", | ||
| "@types/vscode": "~1.51.0", | ||
| "@types/vscode": "~1.53.0", |
There was a problem hiding this comment.
Why is this different than the version of the engine?
There was a problem hiding this comment.
None of the API we are using for Notebooks is in stable, its all proposed API.
Hence there's no need to change this to 1.54
| }, | ||
| "engines": { | ||
| "vscode": "^1.53.0" | ||
| "vscode": "^1.54.0" |
There was a problem hiding this comment.
@brettcannon We don't want anyone on any older version of VS Code to get this new update.
The API changes are not backwards compatible.
Hence the restriction to ensure only those with 1.54 get this update.
There was a problem hiding this comment.
ensure only those with 1.54 get this update
@DonJayamanne then should this be "1.54.0" instead of "^1.54.0"?
There was a problem hiding this comment.
VSCode didn't like that in the engines setting, i think its not supported, leaving as ^.
|
Added another commit to resolve the smoke tests. |
No description provided.