Skip to content

Fix nosetests to run tests only once#15400

Merged
kimadeline merged 2 commits into
microsoft:mainfrom
djplt:nosetest-running-twice
Feb 17, 2021
Merged

Fix nosetests to run tests only once#15400
kimadeline merged 2 commits into
microsoft:mainfrom
djplt:nosetest-running-twice

Conversation

@djplt
Copy link
Copy Markdown

@djplt djplt commented Feb 13, 2021

Fixing issue #6043

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 13, 2021

Codecov Report

Merging #15400 (5f01e9b) into main (334a3bb) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #15400   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        560      560           
  Lines      26854    26873   +19     
  Branches    3877     3883    +6     
======================================
+ Hits       17497    17512   +15     
- Misses      8636     8638    +2     
- Partials     721      723    +2     
Impacted Files Coverage Δ
src/client/testing/nosetest/runner.ts 17% <ø> (ø)
...discovery/locators/services/windowsStoreLocator.ts 93% <0%> (-7%) ⬇️
...covery/locators/services/posixKnownPathsLocator.ts 100% <0%> (ø)
...nments/discovery/locators/services/pyenvLocator.ts 69% <0%> (+<1%) ⬆️

@djplt djplt force-pushed the nosetest-running-twice branch from 9d4afc4 to a4ef9cd Compare February 13, 2021 18:51
@djplt djplt force-pushed the nosetest-running-twice branch from a4ef9cd to 9232e9f Compare February 13, 2021 18:55
@ghost
Copy link
Copy Markdown

ghost commented Feb 13, 2021

CLA assistant check
All CLA requirements met.

Copy link
Copy Markdown

@kimadeline kimadeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂

Comment thread news/2 Fixes/6043.md Outdated
@kimadeline kimadeline added the skip tests Updates to tests unnecessary label Feb 16, 2021
Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
@kimadeline kimadeline merged commit 096cc9e into microsoft:main Feb 17, 2021
@kimadeline
Copy link
Copy Markdown

Insiders tests are failing because the notebook API changed (#15416 should fix it). Failures are unrelated to this PR, merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants