Allow plugins to provide a list of external files.#15308
Merged
Conversation
| // by the LSHost for files in the program when the program is retrieved above but | ||
| // the program doesn't contain external files so this must be done explicitly. | ||
| inserted => { | ||
| const scriptInfo = this.projectService.getOrCreateScriptInfo(inserted, false); |
Member
There was a problem hiding this comment.
15:47:16 src/server/project.ts
15:47:16 ERROR: 579:92 boolean-trivia Tag boolean argument with parameter name
| const bItem = b[bIndex]; | ||
| const compareResult = compare(aItem, bItem); | ||
| if (compareResult < 0) { | ||
| inserted(aItem) |
Member
There was a problem hiding this comment.
15:47:16 src/server/utilities.ts
15:47:16 ERROR: 204:32 semicolon Missing semicolon
| export function enumerateInsertsAndDeletes<T>(a: SortedReadonlyArray<T>, b: SortedReadonlyArray<T>, inserted: (item: T) => void, deleted: (item: T) => void, compare?: (a: T, b: T) => number) { | ||
| if (!compare) compare = (a, b) => a > b ? 1 : a < b ? -1 : 0; | ||
| let aIndex = 0, aLen = a.length; | ||
| let bIndex = 0, bLen = b.length; |
Member
There was a problem hiding this comment.
15:47:16 src/server/utilities.ts
15:47:16 ERROR: 197:25 prefer-const Identifier 'aLen' is never reassigned; use 'const' instead of 'let'.
15:47:16 ERROR: 198:25 prefer-const Identifier 'bLen' is never reassigned; use 'const' instead of 'let'.
| } | ||
|
|
||
| export function enumerateInsertsAndDeletes<T>(a: SortedReadonlyArray<T>, b: SortedReadonlyArray<T>, inserted: (item: T) => void, deleted: (item: T) => void, compare?: (a: T, b: T) => number) { | ||
| if (!compare) compare = (a, b) => a > b ? 1 : a < b ? -1 : 0; |
Member
There was a problem hiding this comment.
Curlies, also consider
compare = compare || ts.compareValuesif its semantics work well enough on undefined values.
| }, | ||
| removed => { | ||
| const scriptInfoToDetach = this.projectService.getScriptInfo(removed); | ||
| if (scriptInfoToDetach) |
| getExternalFiles(): string[] { | ||
| return []; | ||
| getExternalFiles(): SortedReadonlyArray<string> { | ||
| return [] as any as SortedReadonlyArray<string>; |
Member
There was a problem hiding this comment.
Could you not just use emptyArray?
| if (compareResult < 0) { | ||
| inserted(aItem) | ||
| aIndex++; | ||
| } else if (compareResult > 0) { |
Member
|
Looks like some lint failures (run |
Contributor
Author
|
@RyanCavanaugh For some reason I cannot get |
Member
|
@chuckjaz I'm not aware of any problems. What's the console output? |
Contributor
Author
|
@RyanCavanaugh I found out what it is. I had a very old |
The list of the plugin's external files and request made to a file in the list will be routed to an instance of the plugin.
dd2755a to
785c281
Compare
|
Any update on this? |
Contributor
|
@RyanCavanaugh can you please review this change |
RyanCavanaugh
approved these changes
May 27, 2017
Member
|
LGTM |
Member
|
@mhegazy please merge once you've given a quick sanity check as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of the plugin's external files and request made to
a file in the list will be routed to an instance of the plugin.