feat(language-service): provide external file list to TypeScript#16417
Closed
chuckjaz wants to merge 1 commit into
Closed
feat(language-service): provide external file list to TypeScript#16417chuckjaz wants to merge 1 commit into
chuckjaz wants to merge 1 commit into
Conversation
Also ensures that it only calls base language service for files that it contains.
40bd25e to
1179160
Compare
tbosch
reviewed
Apr 28, 2017
| // Create the proxy | ||
| const proxy: ts.LanguageService = Object.create(null); | ||
| const oldLS: ts.LanguageService = info.languageService; | ||
| let oldLS: ts.LanguageService = info.languageService; |
Contributor
There was a problem hiding this comment.
Add comment / link for the bug in TS
tbosch
approved these changes
Apr 28, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ular#16417) Also ensures that it only calls base language service for files that it contains. PR Close angular#16417
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ular#16417) Also ensures that it only calls base language service for files that it contains. PR Close angular#16417
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ensures that it only calls base language service for files
that it contains.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The templates referenced by the project are not communicated to TypeScript.
What is the new behavior?
The templates referenced by the project can be queried by TypeScript's plugin system to allow directing requests about those files to the plugin.
This relies on microsoft/TypeScript#15308 or similar change landing to be enabled.
Does this PR introduce a breaking change? (check one with "x")