Move comparer types to public namespace#17437
Conversation
|
Should those server utilities be public in the first place? |
|
@Andy-MS |
|
|
|
I don't think there's a need to allow third-parties to call those, so they could be made internal. @sheetalkamat might be able to confirm. |
|
@Andy-MS @chuckjaz Added the Considering these are helpers for working with |
|
I didn't have any intents with regards to public APIs since I didn't realize I was changing them. It doesn't sound like |
|
I agree with @Andy-MS as to not have these server utility functions public but to have them as internal instead. |
890d5a7 to
7dcb5c1
Compare
|
@Andy-MS @sheetalkamat done. I've moved the offending types into an internal half of the namespace. |
Fixes #16782
TSServer exports some functions which take in
comparerfunctions - functions whose return value is an instance of ourComparisonenum. BothComparer<T>andComparisonwere in our internal namespace incore.ts(and thus elided from our.d.ts), but they must be public to create a valid.d.tsfortsserverlibrary, which uses these in its exported signatures.