refactor(): remove old animation utility#19586
Merged
Merged
Conversation
* Remove close button * update tests * update tests * add build
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
BREAKING CHANGES Removes `scss` files from the distributed files. Please use CSS variables for theming instead.
BREAKING CHANGES The Ionic default colors have been updated to the following: primary: #3880ff secondary: #3dc2ff tertiary: #5260ff success: #2dd36f warning: #ffc409 danger: #eb445a light: #f4f5f8 medium: #92949c dark: #222428 `primary`, `light` and `dark` have not changed. The contrast color for `warning` has been updated to `#000`.
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
BREAKING CHANGES Skeleton text's `width` property has been removed. Please use CSS instead to set the width.
BREAKING CHANGES The deprecated `ion-anchor` component has been removed in favor using `ion-router-link`. It should still only be used with vanilla and Stencil JavaScript projects. For Angular projects, use an `<a>` and `routerLink` with the Angular router.
) BREAKING CHANGES The `show-cancel-button` property of the searchbar no longer accepts boolean values. Accepted values are strings: `"focus"`, `"always"`, `"never"`. The following should change: ``` <ion-searchbar show-cancel-button> <ion-searchbar show-cancel-button="true"> <ion-searchbar show-cancel-button="false"> ``` becomes ``` <ion-searchbar show-cancel-button="focus"> <ion-searchbar show-cancel-button="focus"> <ion-searchbar show-cancel-button="never"> ```
* Remove close button * update tests * update tests * add build
BREAKING CHANGES Removes ion-nav-pop, ion-nav-push and ion-nav-set-root in favor of using ion-nav-link with router-direction
BREAKING CHANGES Removes `scss` files from the distributed files. Please use CSS variables for theming instead.
BREAKING CHANGES The Ionic default colors have been updated to the following: primary: #3880ff secondary: #3dc2ff tertiary: #5260ff success: #2dd36f warning: #ffc409 danger: #eb445a light: #f4f5f8 medium: #92949c dark: #222428 `primary`, `light` and `dark` have not changed. The contrast color for `warning` has been updated to `#000`.
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
BREAKING CHANGES Skeleton text's `width` property has been removed. Please use CSS instead to set the width.
BREAKING CHANGES The deprecated `ion-anchor` component has been removed in favor using `ion-router-link`. It should still only be used with vanilla and Stencil JavaScript projects. For Angular projects, use an `<a>` and `routerLink` with the Angular router.
) BREAKING CHANGES The `show-cancel-button` property of the searchbar no longer accepts boolean values. Accepted values are strings: `"focus"`, `"always"`, `"never"`. The following should change: ``` <ion-searchbar show-cancel-button> <ion-searchbar show-cancel-button="true"> <ion-searchbar show-cancel-button="false"> ``` becomes ``` <ion-searchbar show-cancel-button="focus"> <ion-searchbar show-cancel-button="focus"> <ion-searchbar show-cancel-button="never"> ```
BREAKING CHANGES
The responsive display classes found in the `display.css` file have had their media queries updated to better reflect how they should work. Instead of using the maximum value of that breakpoint (for `.ion-hide-{breakpoint}-down` classes) the maximum of the media query will be the minimum of that breakpoint.
fixes #18600
brandyscarney
requested changes
Oct 9, 2019
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Can you fix conflicts on this
BREAKING CHANGES The Events Service in @ionic/angular has been removed. - Use "Observables" for a similar pub/sub architecture: https://angular.io/guide/observables - Use "Redux" for advanced state management: https://ngrx.io
1f58162 to
6d44e76
Compare
brandyscarney
approved these changes
Oct 11, 2019
elylucas
pushed a commit
that referenced
this pull request
Oct 30, 2019
Use Ionic Animations instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
This PR removes the old animation utility in favor of Ionic Animations
Does this introduce a breaking change?
Other information