refactor(css): remove CSS util attributes#18956
Merged
Merged
Conversation
* Remove close button * update tests * update tests * add build
28411d6 to
e8b2842
Compare
bc99f4e to
76f1747
Compare
brandyscarney
added a commit
that referenced
this pull request
Oct 7, 2019
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
brandyscarney
added a commit
that referenced
this pull request
Oct 8, 2019
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
brandyscarney
added a commit
that referenced
this pull request
Oct 9, 2019
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
brandyscarney
added a commit
that referenced
this pull request
Oct 10, 2019
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
elylucas
pushed a commit
that referenced
this pull request
Oct 30, 2019
BREAKING CHANGES Removes all CSS utility attributes. Please use CSS classes instead. See the documentation for the correct class names: https://ionicframework.com/docs/layout/css-utilities
rtpHarry
reviewed
Nov 17, 2019
rtpHarry
left a comment
Contributor
There was a problem hiding this comment.
Couple of typos in the comments for this pr have slipped through
| @@ -12,43 +12,35 @@ | |||
| @include media-breakpoint-up($breakpoint, $screen-breakpoints) { | |||
| // Provide `[text-{bp}]` attributes for aligning the text based | |||
Contributor
There was a problem hiding this comment.
Comment still refers to directive
| @@ -12,20 +12,17 @@ | |||
| @include media-breakpoint-up($breakpoint, $screen-breakpoints) { | |||
| // Provide `[text-{bp}]` attributes for transforming the text based | |||
Contributor
There was a problem hiding this comment.
Comment still refers to directive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ READY - deprecation warning in v4 ✅
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
The documentation has been updated to use classes for a few releases now.
Other information