refactor(): remove no-border references#18954
Merged
Merged
Conversation
Member
|
What's the alternative here? |
Contributor
Author
|
@brandyscarney You can use |
brandyscarney
requested changes
Jul 30, 2019
brandyscarney
left a comment
Member
There was a problem hiding this comment.
I spoke with Liam about this on Slack, since this is working in v4 without any deprecation warnings we want to add a feature to hide the border using a boolean CSS variable like the following:
--show-border: 0;
Which would act to hide the border (by calculating against the height). This would allow the users an alternative over targeting the display in the ::after or ::before for md.
bc99f4e to
76f1747
Compare
Contributor
Author
|
Updated branch to add |
brandyscarney
approved these changes
Sep 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
no-borderreferences existed in the CSS for ion-footer and ion-header, and references existed in tests for ion-searchbar and ion-contentWhat is the new behavior?
There are no more references to
no-borderAlternative: Use
.ion-no-borderDoes this introduce a breaking change?
Other information