Restrict access to MailerController actions#177
Merged
PragTob merged 1 commit intohacketyhack:masterfrom Nov 2, 2013
Merged
Conversation
PragTob
added a commit
that referenced
this pull request
Nov 2, 2013
Restrict access to MailerController actions
Member
|
Wow this looks brilliant, thank you so much for your contribution! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a fix for issue #175 - a small change, but I did need to alter the MailerController's controller specs so they could handle the different contexts of being accessed by a moderator, normal user, or guest.
Let me know if you have concerns with the way I tested this (or anything else). Thanks for your help!