Skip to content

Restrict access to MailerController actions #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PragTob merged 1 commit into from
Nov 2, 2013
Merged

Restrict access to MailerController actions #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/mailer_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
class MailerController < ApplicationController
load_and_authorize_resource class: Message

def new
@users = Array(params[:user])
@emails = User.where(:username => @users).all.map(&:email)
Expand Down
123 changes: 97 additions & 26 deletions spec/controllers/mailer_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,58 @@
describe MailerController do
let(:user) { Fabricate(:user) }
let(:users) { Fabricate.sequence(:user, 5)}
let(:diffusion) { Fabricate.build(:diffusion) }

shared_examples 'unauthorized' do
it 'redirects to the login page' do
response.should redirect_to(login_path)
end
end

describe "GET 'new' for a single user email" do
it "returns http success" do
get :new, user: Array(user)
response.should be_success

context 'when user is a moderator' do
before { sign_in Fabricate(:user, moderator: true) }
it "returns http success" do
get :new, user: Array(user)
response.should be_success
end
end

context 'when user is not a moderator' do
before do
sign_in Fabricate(:user)
get :new, user: Array(user)
end
it_behaves_like 'unauthorized'
end

context 'when user is a guest' do
before { get :new, user: Array(user) }
it_behaves_like 'unauthorized'
end
end

describe "GET 'new' for a diffusion" do
it "returns http success" do
get :new, user: Array(users)
response.should be_success
context 'when user is a moderator' do
before { sign_in Fabricate(:user, moderator: true) }
it "returns http success" do
get :new, user: Array(users)
response.should be_success
end
end

context 'when user is not a moderator' do
before do
sign_in Fabricate(:user)
get :new, user: Array(users)
end
it_behaves_like 'unauthorized'
end

context 'when user is a guest' do
before { get :new, user: Array(users) }
it_behaves_like 'unauthorized'
end
end

Expand All @@ -23,37 +63,68 @@
@message = Fabricate.build(:message)
end

it 'delivers the email' do
expect {
post :create, message: @message
}.to change {ActionMailer::Base.deliveries.size}.by(1)
context 'when user is a moderator' do
before { sign_in Fabricate(:user, moderator: true) }
it 'delivers the email' do
expect {
post :create, message: @message
}.to change {ActionMailer::Base.deliveries.size}.by(1)
end

describe 'delivered message' do
before :each do
post :create, message: @message
end

it "returns http success" do
response.should be_redirect
end

it 'delivers the mail with the subject that we wanted to' do
ActionMailer::Base.deliveries.last.subject.should == @message.subject
end

it 'delivers the mail with the body that we wanted to' do
ActionMailer::Base.deliveries.last.body.to_s.should match @message.body
end
end
end

describe 'delivered message' do
before :each do
context 'when user is not a moderator' do
before do
sign_in Fabricate(:user)
post :create, message: @message
end
it_behaves_like 'unauthorized'
end

it "returns http success" do
response.should be_redirect
end
context 'when user is a guest' do
before { post :create, message: @message }
it_behaves_like 'unauthorized'
end
end

it 'delivers the mail with the subject that we wanted to' do
ActionMailer::Base.deliveries.last.subject.should == @message.subject
describe "POST 'create' for a diffusion" do
context 'when user is a moderator' do
before { sign_in Fabricate(:user, moderator: true) }
it "returns http success" do
expect {
post 'create', message: diffusion
}.to change {ActionMailer::Base.deliveries.size}.by(diffusion.email.size)
end
end

it 'delivers the mail with the body that we wanted to' do
ActionMailer::Base.deliveries.last.body.to_s.should match @message.body
context 'when user is not a moderator' do
before do
sign_in Fabricate(:user)
post :create, message: diffusion
end
it_behaves_like 'unauthorized'
end
end

describe "POST 'create' for a diffusion" do
it "returns http success" do
@diffusion = Fabricate.build(:diffusion)
expect {
post 'create', message: @diffusion
}.to change {ActionMailer::Base.deliveries.size}.by(@diffusion.email.size)
context 'when user is a guest' do
before { post :create, message: diffusion }
it_behaves_like 'unauthorized'
end
end
end