chore: consolidate config for google-django-spanner#16657
chore: consolidate config for google-django-spanner#16657
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .librarian/config.yaml file by adding a generate_blocked flag to the google-django-spanner library and removing the django-google-spanner entry. The review feedback suggests reordering the YAML keys for google-django-spanner to maintain consistency with the existing entries in the configuration file.
| - id: google-django-spanner | ||
| generate_blocked: true | ||
| release_blocked: true |
There was a problem hiding this comment.
For consistency with other entries in this configuration file, it is recommended to place the generate_blocked key first in the list item. This aligns with the pattern seen in other entries like google-cloud-storage and db-dtypes where status flags precede the library identifier.
- generate_blocked: true
id: google-django-spanner
release_blocked: trueThere was a problem hiding this comment.
This is the wrong way round. django-google-spanner is the correct name, both in terms of files and state file entries.
See #16654 (comment)