Skip to content

chore: consolidate config for google-django-spanner #16657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parthea wants to merge 1 commit into from
+1 −2
Closed

chore: consolidate config for google-django-spanner #16657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .librarian/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ global_files_allowlist:
permissions: read-write
libraries:
- id: google-django-spanner
generate_blocked: true
release_blocked: true
Comment on lines 8 to 10
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other entries in this configuration file, it is recommended to place the generate_blocked key first in the list item. This aligns with the pattern seen in other entries like google-cloud-storage and db-dtypes where status flags precede the library identifier.

  - generate_blocked: true
    id: google-django-spanner
    release_blocked: true

Copy link
Copy Markdown
Contributor

@jskeet jskeet Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong way round. django-google-spanner is the correct name, both in terms of files and state file entries.

- generate_blocked: true
id: google-cloud-storage
Expand All @@ -32,8 +33,6 @@ libraries:
id: bigquery-magics
- generate_blocked: true
id: db-dtypes
- generate_blocked: true
id: django-google-spanner
- generate_blocked: true
id: gapic-generator
- generate_blocked: true
Expand Down
Loading