chore: migrate remaining libraries to librarian (config only)#16654
chore: migrate remaining libraries to librarian (config only)#16654jskeet merged 2 commits intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .librarian/config.yaml file by adding numerous libraries and setting the generate_blocked flag to true for both new and existing entries. A review comment identifies a duplicate entry for the Django Spanner library and suggests consolidating them to avoid redundancy.
| - generate_blocked: true | ||
| id: django-google-spanner |
There was a problem hiding this comment.
The library django-google-spanner appears to be a duplicate of google-django-spanner (line 8). These should be consolidated to avoid redundancy. Since django-google-spanner is the current name of the package, it is recommended to rename the existing entry at line 8 and remove this new one.
There was a problem hiding this comment.
+1 There is a duplicate entry but it's not clear if it will cause an issue. FYI @jskeet
There was a problem hiding this comment.
That's really odd. I have no idea how that happened... will fix.
There was a problem hiding this comment.
Ah, no it's not a duplicate - basically I think it was a typo when google-django-spanner on line 8 was added manually in #16181.
Still, I've fixed it to be release-blocked in this PR, removing the incorrect entry.
There was a problem hiding this comment.
Whoops, this was merged before my fix - will approve #16657.
These will be regenerated in batches.
These will be regenerated in batches.