Skip to content

JS: recognize tagged template literals as DataFlow::CallNode #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erik-krogh merged 7 commits into from
Oct 11, 2023
Merged

JS: recognize tagged template literals as DataFlow::CallNode #14405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
951ed01
combine the `library-tests/CallGraphs/FullTest` tests into one file
erik-krogh Oct 6, 2023
18e6a54
recognize tagged templates as `DataFlow::CallNode`
erik-krogh Oct 6, 2023
9b65017
add API-graph test for the new tagged template calls
erik-krogh Oct 6, 2023
7ca0996
add a taint-tracking tests for calls to tagged template strings
erik-krogh Oct 6, 2023
56e9eda
fix performance by caching `getArgument`
erik-krogh Oct 6, 2023
d261cec
add change-note
erik-krogh Oct 7, 2023
6377e92
Update javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
erik-krogh Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add API-graph test for the new tagged template calls
  • Loading branch information
@erik-krogh
erik-krogh committed Oct 6, 2023
commit 9b6501787a96e1a78fdc52c0e6ecc01d9e98dea3
Empty file added javascript/ql/test/ApiGraphs/tagged-template/VerifyAssertions.expected
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions javascript/ql/test/ApiGraphs/tagged-template/VerifyAssertions.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import ApiGraphs.VerifyAssertions
9 changes: 9 additions & 0 deletions javascript/ql/test/ApiGraphs/tagged-template/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const tag = require("tag");

tag.string`string1
${23}` // def=moduleImport("tag").getMember("exports").getMember("string").getParameter(1)

tag.highlight`string2
${23}
morestring
${42}` // def=moduleImport("tag").getMember("exports").getMember("highlight").getParameter(2)
3 changes: 3 additions & 0 deletions javascript/ql/test/ApiGraphs/tagged-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"name": "tagged-template"
}