Skip to content

JS: recognize tagged template literals as DataFlow::CallNode #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erik-krogh merged 7 commits into from
Oct 11, 2023
Merged

JS: recognize tagged template literals as DataFlow::CallNode #14405

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
951ed01
combine the `library-tests/CallGraphs/FullTest` tests into one file
erik-krogh Oct 6, 2023
18e6a54
recognize tagged templates as `DataFlow::CallNode`
erik-krogh Oct 6, 2023
9b65017
add API-graph test for the new tagged template calls
erik-krogh Oct 6, 2023
7ca0996
add a taint-tracking tests for calls to tagged template strings
erik-krogh Oct 6, 2023
56e9eda
fix performance by caching `getArgument`
erik-krogh Oct 6, 2023
d261cec
add change-note
erik-krogh Oct 7, 2023
6377e92
Update javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
erik-krogh Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll 
Co-authored-by: Asger F <asgerf@github.com>
  • Loading branch information
@erik-krogh @asgerf
erik-krogh and asgerf authored Oct 11, 2023
commit 6377e920671d09276f48a6b79db8a04c73e28888
2 changes: 1 addition & 1 deletion javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ module DataFlow {
override DataFlow::Node getCalleeNode() { result = DataFlow::valueNode(astNode.getTag()) }

override DataFlow::Node getArgument(int i) {
// the first parameter send to the function is the string parts, which we don't model.
// the first argument sent to the function is the array of string parts, which we don't model.
// rank is 1-indexed, which is perfect here.
result =
DataFlow::valueNode(rank[i](Expr e, int index |
Expand Down