Skip to content

JS: recognize tagged template literals as DataFlow::CallNode #14405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erik-krogh merged 7 commits into from
Oct 11, 2023
Merged

JS: recognize tagged template literals as DataFlow::CallNode #14405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
951ed01
combine the `library-tests/CallGraphs/FullTest` tests into one file
erik-krogh Oct 6, 2023
18e6a54
recognize tagged templates as `DataFlow::CallNode`
erik-krogh Oct 6, 2023
9b65017
add API-graph test for the new tagged template calls
erik-krogh Oct 6, 2023
7ca0996
add a taint-tracking tests for calls to tagged template strings
erik-krogh Oct 6, 2023
56e9eda
fix performance by caching `getArgument`
erik-krogh Oct 6, 2023
d261cec
add change-note
erik-krogh Oct 7, 2023
6377e92
Update javascript/ql/lib/semmle/javascript/dataflow/DataFlow.qll
erik-krogh Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix performance by caching getArgument
  • Loading branch information
@erik-krogh
erik-krogh committed Oct 7, 2023
commit 56e9eda2b90b7f9b2c168a360a831d3d5f9dca6f
13 changes: 10 additions & 3 deletions javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,20 @@ class InvokeNode extends DataFlow::SourceNode instanceof DataFlow::Impl::InvokeN
* but the position of `z` cannot be determined, hence there are no first and second
* argument nodes.
*/
DataFlow::Node getArgument(int i) { result = super.getArgument(i) }
cached
DataFlow::Node getArgument(int i) {
result = super.getArgument(i) and Stages::DataFlowStage::ref()
}

/** Gets the data flow node corresponding to an argument of this invocation. */
DataFlow::Node getAnArgument() { result = super.getAnArgument() }
cached
DataFlow::Node getAnArgument() { result = super.getAnArgument() and Stages::DataFlowStage::ref() }

/** Gets the data flow node corresponding to the last argument of this invocation. */
DataFlow::Node getLastArgument() { result = this.getArgument(this.getNumArgument() - 1) }
cached
DataFlow::Node getLastArgument() {
result = this.getArgument(this.getNumArgument() - 1) and Stages::DataFlowStage::ref()
}

/**
* Gets a data flow node corresponding to an array of values being passed as
Expand Down
6 changes: 6 additions & 0 deletions javascript/ql/lib/semmle/javascript/internal/CachedStages.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,12 @@ module Stages {
exists(any(DataFlow::PropRef ref).getBase())
or
exists(any(DataFlow::ClassNode cls))
or
exists(any(DataFlow::CallNode node).getArgument(_))
or
exists(any(DataFlow::CallNode node).getAnArgument())
or
exists(any(DataFlow::CallNode node).getLastArgument())
}
}

Expand Down