[Impeller] Fix fail to render pixel buffer texture on Linux by xiaowei-guan · Pull Request #181656 · flutter/flutter

xiaowei-guan · 2026-01-29T08:29:52Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

flutter-dashboard · 2026-01-29T08:29:56Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request fixes an issue with rendering external OpenGL textures with Impeller on Linux. The changes include explicitly setting the texture format, using the correct texture name (ID) instead of the target when creating the Impeller texture handle, and setting the texture coordinate system to kUploadFromHost to ensure correct orientation.

I've suggested an improvement to avoid hardcoding the pixel format and instead derive it from the texture->format provided by the embedder, which would make the implementation more robust.

gaaclarke

@xiaowei-guan this PR doesn't have a test, unfortunately I'm not that familiar with this code so I can't give you a pointer on the best way to test it and I'm not readily seeing unit testing set up here. I cannot approve it without some sort of test though.

xiaowei-guan · 2026-02-03T06:05:02Z

@xiaowei-guan this PR doesn't have a test, unfortunately I'm not that familiar with this code so I can't give you a pointer on the best way to test it and I'm not readily seeing unit testing set up here. I cannot approve it without some sort of test though.

OK, I will add unit test later.

loic-sharma · 2026-02-04T00:00:26Z

For a test, these might be useful resources for prior art you can copy:

This is the C++ code that launches the engine to render some content using OpenGL + Impeller:

flutter/engine/src/flutter/shell/platform/embedder/tests/embedder_gl_unittests.cc

Lines 4773 to 4830 in 9b9f997

    
           TEST_F(EmbedderTest, CanRenderWithImpellerOpenGL) { 
        
             auto& context = GetEmbedderContext<EmbedderTestContextGL>(); 
        
             EmbedderConfigBuilder builder(context); 
        
             bool present_called = false; 
        
             context.SetGLPresentCallback( 
        
                 [&present_called](FlutterPresentInfo present_info) { 
        
                   present_called = true; 
        
                 }); 
        
             builder.AddCommandLineArgument("--enable-impeller"); 
        
             builder.SetDartEntrypoint("render_impeller_test"); 
        
             builder.SetSurface(DlISize(800, 600)); 
        
             builder.SetCompositor(); 
        
             builder.SetRenderTargetType( 
        
                 EmbedderTestBackingStoreProducer::RenderTargetType::kOpenGLFramebuffer); 
        
             auto rendered_scene = context.GetNextSceneImage(); 
        
             auto engine = builder.LaunchEngine(); 
        
             ASSERT_TRUE(engine.is_valid()); 
        
             // Bind to an arbitrary FBO in order to verify that Impeller binds to the 
        
             // provided FBO during rendering. 
        
             typedef void (*glGenFramebuffersProc)(GLsizei n, GLuint* ids); 
        
             typedef void (*glBindFramebufferProc)(GLenum target, GLuint framebuffer); 
        
             auto glGenFramebuffers = reinterpret_cast<glGenFramebuffersProc>( 
        
                 context.GLGetProcAddress("glGenFramebuffers")); 
        
             auto glBindFramebuffer = reinterpret_cast<glBindFramebufferProc>( 
        
                 context.GLGetProcAddress("glBindFramebuffer")); 
        
             const flutter::Shell& shell = ToEmbedderEngine(engine.get())->GetShell(); 
        
             fml::AutoResetWaitableEvent raster_event; 
        
             shell.GetTaskRunners().GetRasterTaskRunner()->PostTask([&] { 
        
               GLuint fbo; 
        
               glGenFramebuffers(1, &fbo); 
        
               glBindFramebuffer(GL_FRAMEBUFFER, fbo); 
        
               raster_event.Signal(); 
        
             }); 
        
             raster_event.Wait(); 
        
             // Send a window metrics events so frames may be scheduled. 
        
             FlutterWindowMetricsEvent event = {}; 
        
             event.struct_size = sizeof(event); 
        
             event.width = 800; 
        
             event.height = 600; 
        
             event.pixel_ratio = 1.0; 
        
             ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), 
        
                       kSuccess); 
        
             ASSERT_TRUE(ImageMatchesFixture( 
        
                 FixtureNameForBackend(EmbedderTestContextType::kOpenGLContext, 
        
                                       "impeller_test.png"), 
        
                 rendered_scene)); 
        
             // The scene will be rendered by the compositor, and the surface present 
        
             // callback should not be invoked. 
        
             ASSERT_FALSE(present_called); 
        
           }

This is the Dart code that renders some content:

flutter/engine/src/flutter/shell/platform/embedder/fixtures/main.dart

Lines 1560 to 1576 in 9b9f997

    
           @pragma('vm:entry-point') 
        
           // ignore: non_constant_identifier_names 
        
           void render_impeller_test() { 
        
             PlatformDispatcher.instance.onBeginFrame = (Duration duration) { 
        
               final builder = SceneBuilder(); 
        
               builder.pushOffset(0.0, 0.0); 
        
               final paint = Paint(); 
        
               paint.color = const Color.fromARGB(255, 0, 0, 255); 
        
               final baseRecorder = PictureRecorder(); 
        
               final canvas = Canvas(baseRecorder); 
        
               canvas.drawPaint(Paint()..color = const Color.fromARGB(255, 255, 0, 0)); 
        
               canvas.drawRect(const Rect.fromLTRB(20.0, 20.0, 200.0, 150.0), paint); 
        
               builder.addPicture(Offset.zero, baseRecorder.endRecording()); 
        
               builder.pop(); 
        
               PlatformDispatcher.instance.views.first.render(builder.build()); 
        
             }; 
        
             PlatformDispatcher.instance.scheduleFrame();

This is the snapshot of the expected test output: https://github.com/flutter/flutter/blob/9b9f9975c76a1474b96426d22cd34cc589ad6f53/engine/src/flutter/shell/platform/embedder/fixtures/impeller_test.png

xiaowei-guan · 2026-02-09T11:35:39Z

@xiaowei-guan this PR doesn't have a test, unfortunately I'm not that familiar with this code so I can't give you a pointer on the best way to test it and I'm not readily seeing unit testing set up here. I cannot approve it without some sort of test though.

@gaaclarke I have added a unit test for rendering a impeller texture.

gaaclarke

This is awesome, thanks. Can you make one change though please, can you make the texture sensitive to orientation so we can assert your change to the images coordinate system?

gaaclarke

lgtm! thanks

jason-simmons

Thanks for fixing this!

auto-submit · 2026-02-11T17:16:19Z

autosubmit label was removed for flutter/flutter/181656, because - The status or check suite Windows tool_integration_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Windows tool_integration_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_5_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows tool_integration_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_test_android_standard has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_test_android_variants has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_android_host_app_with_module_aar has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows gradle_plugin_bundle_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_9_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_8_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_7_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_6_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_5_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_4_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_3_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows build_tests_1_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

xiaowei-guan · 2026-02-12T09:15:38Z

Rebased

fluttergithubbot · 2026-02-12T09:30:36Z

An existing Git SHA, 8004628ca0401a70bec720d16800ae8b71f43eae, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

gaaclarke · 2026-02-12T17:05:42Z

Notes from google testing: There is a merge conflict in the PR that cannot be rolled cleanly, please rebase the PR.

We just rebased, but I'll try again.

gaaclarke · 2026-02-12T17:06:28Z

jinx

auto-submit · 2026-02-12T17:08:13Z

autosubmit label was removed for flutter/flutter/181656, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2026-02-12T17:18:09Z

autosubmit label was removed for flutter/flutter/181656, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

xiaowei-guan · 2026-02-24T05:59:41Z

I have rebased locally against upstream/master and forced pushed, but the g3 conflict persists. Could a maintainer help check if this is an internal sync issue?

1.Make the texture red on the top half and blue on the botton half. 2.Add a new image file.

Only support GL_RGBA8 format now.

gaaclarke · 2026-02-24T16:26:27Z

It's reporting a merge conflict, I tried to hit the button to attempt again but no luck. There is zero feedback about where the merge conflict is happening. I'll try reaching out to someone that works on this tool.

…flutter/flutter#181656)

Roll Flutter from dad6f9d4107a to b31548feb941 (39 revisions) flutter/flutter@dad6f9d...b31548f 2026-02-25 mdebbar@google.com [web] Fix failure on Firefox 148 (flutter/flutter#182855) 2026-02-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KfPgw04T0OEADLJA5... to XI0Ax7fbtYE4XKYAQ... (flutter/flutter#182887) 2026-02-25 50643541+Mairramer@users.noreply.github.com Use AnimationStyle curve and reverseCurve in ModalBottomSheet animation (flutter/flutter#181403) 2026-02-25 engine-flutter-autoroll@skia.org Roll Dart SDK from fd3dce5b6a4e to 5c57e75f1102 (9 revisions) (flutter/flutter#182801) 2026-02-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "refactor: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (#182697)" (flutter/flutter#182879) 2026-02-25 ahmedsameha1@gmail.com Make sure that an AnimatedSlide doesn't crash in 0x0 environment (flutter/flutter#181535) 2026-02-24 jmccandless@google.com Reland Standardize on Test* widgets in *_tester.dart files (flutter/flutter#182632) 2026-02-24 nhan13574@gmail.com docs(Path): clarify that zero-length contours are excluded from computeMetrics (flutter/flutter#180165) 2026-02-24 mdebbar@google.com Fix typo in assert message (flutter/flutter#182843) 2026-02-24 matej.knopp@gmail.com [win32] Fix overflow in TaskRunnerWindow. (flutter/flutter#182822) 2026-02-24 abadasamuelosp@gmail.com feat: Add --no-uninstall flag to flutter test for integration tests (flutter/flutter#182714) 2026-02-24 74057391+jhonathanqz@users.noreply.github.com Rename noFrequencyBasedMinification to useFrequencyBasedMinification (flutter/flutter#182684) 2026-02-24 60122246+xiaowei-guan@users.noreply.github.com [Impeller] Fix fail to render pixel buffer texture on Linux (flutter/flutter#181656) 2026-02-24 15619084+vashworth@users.noreply.github.com Remove FlutterFramework app migration (flutter/flutter#182100) 2026-02-24 engine-flutter-autoroll@skia.org Roll Packages from 12b43a1 to 062c8d4 (5 revisions) (flutter/flutter#182839) 2026-02-24 mdebbar@google.com [web] Run webparagraph tests in CI (flutter/flutter#182092) 2026-02-24 jason-simmons@users.noreply.github.com Fix a race in EmbedderTest.CanSpecifyCustomUITaskRunner (flutter/flutter#182649) 2026-02-24 srawlins@google.com flutter_tools: Use a super-parameter in several missed cases (flutter/flutter#182581) 2026-02-24 116356835+AbdeMohlbi@users.noreply.github.com Replace more references to `flutter/engine` with `flutter/flutter` (flutter/flutter#182654) 2026-02-24 50643541+Mairramer@users.noreply.github.com Carousel: Migration from Scrollable+Viewport to CustomScrollView (flutter/flutter#182475) 2026-02-24 97480502+b-luk@users.noreply.github.com Refactor impellerc_main to better organize some of its logic (flutter/flutter#182783) 2026-02-24 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `getPluginList ` (flutter/flutter#182660) 2026-02-24 34465683+rkishan516@users.noreply.github.com Refactor: Remove material from ticker provider test (flutter/flutter#181697) 2026-02-24 engine-flutter-autoroll@skia.org Roll Skia from 26eebffe12bd to f44d7db68805 (3 revisions) (flutter/flutter#182821) 2026-02-24 34465683+rkishan516@users.noreply.github.com refactor: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter/flutter#182697) 2026-02-24 engine-flutter-autoroll@skia.org Roll Skia from 7dad66aae75a to 26eebffe12bd (5 revisions) (flutter/flutter#182810) 2026-02-24 pokepsi@gmail.com Update roadmap for 2026 (flutter/flutter#182798) 2026-02-24 fluttergithubbot@gmail.com Marks Windows tool_tests_commands_1_2 to be unflaky (flutter/flutter#179670) 2026-02-23 zhongliu88889@gmail.com [web] scroll iOS iframe text input into view (flutter/flutter#179759) 2026-02-23 Mail@maikwild.de Fix textscaler clamp assertion error (flutter/flutter#181716) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 9a5a3c92c336 to 7dad66aae75a (4 revisions) (flutter/flutter#182779) 2026-02-23 116356835+AbdeMohlbi@users.noreply.github.com Move more getters from userMessages class to the appropriate places (flutter/flutter#182656) 2026-02-23 engine-flutter-autoroll@skia.org Manual roll Dart SDK from f8fac50475b8 to fd3dce5b6a4e (6 revisions) (flutter/flutter#182768) 2026-02-23 15619084+vashworth@users.noreply.github.com Copy Flutter framework to Add to App FlutterPluginRgistrant (flutter/flutter#182523) 2026-02-23 mr-peipei@web.de Add progress indicator to artifact downloads (flutter/flutter#181808) 2026-02-23 47866232+chunhtai@users.noreply.github.com Clarify batch release mode requirements (flutter/flutter#182228) 2026-02-23 mdebbar@google.com [web] Remove --disable-gpu from flutter chrome tests (flutter/flutter#182618) 2026-02-23 jwren@google.com running-apps: update running-apps to use Duration.ago() (flutter/flutter#182172) 2026-02-23 kevmoo@users.noreply.github.com Refactor bin/ shell scripts for better performance and safety (flutter/flutter#182674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...

…181656) Fix flutter#181483  *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#11116) Roll Flutter from dad6f9d4107a to b31548feb941 (39 revisions) flutter/flutter@dad6f9d...b31548f 2026-02-25 mdebbar@google.com [web] Fix failure on Firefox 148 (flutter/flutter#182855) 2026-02-25 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from KfPgw04T0OEADLJA5... to XI0Ax7fbtYE4XKYAQ... (flutter/flutter#182887) 2026-02-25 50643541+Mairramer@users.noreply.github.com Use AnimationStyle curve and reverseCurve in ModalBottomSheet animation (flutter/flutter#181403) 2026-02-25 engine-flutter-autoroll@skia.org Roll Dart SDK from fd3dce5b6a4e to 5c57e75f1102 (9 revisions) (flutter/flutter#182801) 2026-02-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "refactor: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (#182697)" (flutter/flutter#182879) 2026-02-25 ahmedsameha1@gmail.com Make sure that an AnimatedSlide doesn't crash in 0x0 environment (flutter/flutter#181535) 2026-02-24 jmccandless@google.com Reland Standardize on Test* widgets in *_tester.dart files (flutter/flutter#182632) 2026-02-24 nhan13574@gmail.com docs(Path): clarify that zero-length contours are excluded from computeMetrics (flutter/flutter#180165) 2026-02-24 mdebbar@google.com Fix typo in assert message (flutter/flutter#182843) 2026-02-24 matej.knopp@gmail.com [win32] Fix overflow in TaskRunnerWindow. (flutter/flutter#182822) 2026-02-24 abadasamuelosp@gmail.com feat: Add --no-uninstall flag to flutter test for integration tests (flutter/flutter#182714) 2026-02-24 74057391+jhonathanqz@users.noreply.github.com Rename noFrequencyBasedMinification to useFrequencyBasedMinification (flutter/flutter#182684) 2026-02-24 60122246+xiaowei-guan@users.noreply.github.com [Impeller] Fix fail to render pixel buffer texture on Linux (flutter/flutter#181656) 2026-02-24 15619084+vashworth@users.noreply.github.com Remove FlutterFramework app migration (flutter/flutter#182100) 2026-02-24 engine-flutter-autoroll@skia.org Roll Packages from 12b43a1 to 062c8d4 (5 revisions) (flutter/flutter#182839) 2026-02-24 mdebbar@google.com [web] Run webparagraph tests in CI (flutter/flutter#182092) 2026-02-24 jason-simmons@users.noreply.github.com Fix a race in EmbedderTest.CanSpecifyCustomUITaskRunner (flutter/flutter#182649) 2026-02-24 srawlins@google.com flutter_tools: Use a super-parameter in several missed cases (flutter/flutter#182581) 2026-02-24 116356835+AbdeMohlbi@users.noreply.github.com Replace more references to `flutter/engine` with `flutter/flutter` (flutter/flutter#182654) 2026-02-24 50643541+Mairramer@users.noreply.github.com Carousel: Migration from Scrollable+Viewport to CustomScrollView (flutter/flutter#182475) 2026-02-24 97480502+b-luk@users.noreply.github.com Refactor impellerc_main to better organize some of its logic (flutter/flutter#182783) 2026-02-24 116356835+AbdeMohlbi@users.noreply.github.com Remove unused `getPluginList ` (flutter/flutter#182660) 2026-02-24 34465683+rkishan516@users.noreply.github.com Refactor: Remove material from ticker provider test (flutter/flutter#181697) 2026-02-24 engine-flutter-autoroll@skia.org Roll Skia from 26eebffe12bd to f44d7db68805 (3 revisions) (flutter/flutter#182821) 2026-02-24 34465683+rkishan516@users.noreply.github.com refactor: remove material in context_menu_controller_test, icon_test, list_wheel_scroll_view_test, media_query_test, platform_menu_bar_test (flutter/flutter#182697) 2026-02-24 engine-flutter-autoroll@skia.org Roll Skia from 7dad66aae75a to 26eebffe12bd (5 revisions) (flutter/flutter#182810) 2026-02-24 pokepsi@gmail.com Update roadmap for 2026 (flutter/flutter#182798) 2026-02-24 fluttergithubbot@gmail.com Marks Windows tool_tests_commands_1_2 to be unflaky (flutter/flutter#179670) 2026-02-23 zhongliu88889@gmail.com [web] scroll iOS iframe text input into view (flutter/flutter#179759) 2026-02-23 Mail@maikwild.de Fix textscaler clamp assertion error (flutter/flutter#181716) 2026-02-23 engine-flutter-autoroll@skia.org Roll Skia from 9a5a3c92c336 to 7dad66aae75a (4 revisions) (flutter/flutter#182779) 2026-02-23 116356835+AbdeMohlbi@users.noreply.github.com Move more getters from userMessages class to the appropriate places (flutter/flutter#182656) 2026-02-23 engine-flutter-autoroll@skia.org Manual roll Dart SDK from f8fac50475b8 to fd3dce5b6a4e (6 revisions) (flutter/flutter#182768) 2026-02-23 15619084+vashworth@users.noreply.github.com Copy Flutter framework to Add to App FlutterPluginRgistrant (flutter/flutter#182523) 2026-02-23 mr-peipei@web.de Add progress indicator to artifact downloads (flutter/flutter#181808) 2026-02-23 47866232+chunhtai@users.noreply.github.com Clarify batch release mode requirements (flutter/flutter#182228) 2026-02-23 mdebbar@google.com [web] Remove --disable-gpu from flutter chrome tests (flutter/flutter#182618) 2026-02-23 jwren@google.com running-apps: update running-apps to use Duration.ago() (flutter/flutter#182172) 2026-02-23 kevmoo@users.noreply.github.com Refactor bin/ shell scripts for better performance and safety (flutter/flutter#182674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...

…181656) Fix flutter#181483  *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions Bot added the engine flutter/engine related. See also e: labels. label Jan 29, 2026

gemini-code-assist Bot reviewed Jan 29, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc

This comment was marked as spam.

Sign in to view

gaaclarke reviewed Feb 2, 2026

View reviewed changes

loic-sharma requested a review from robert-ancell February 3, 2026 23:40

gaaclarke self-requested a review February 9, 2026 17:39

gaaclarke requested changes Feb 9, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc

gaaclarke approved these changes Feb 10, 2026

View reviewed changes

jason-simmons reviewed Feb 10, 2026

View reviewed changes

Comment thread engine/src/flutter/shell/platform/embedder/embedder_external_texture_gl.cc

Comment thread engine/src/flutter/shell/platform/embedder/tests/embedder_gl_unittests.cc Outdated

jason-simmons approved these changes Feb 11, 2026

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 11, 2026

xiaowei-guan force-pushed the linux_texture branch from 6fcf525 to 8004628 Compare February 12, 2026 08:33

xiaowei-guan closed this Feb 12, 2026

xiaowei-guan reopened this Feb 12, 2026

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2026

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2026

xiaowei-guan force-pushed the linux_texture branch from 46ac560 to 2df7bd4 Compare February 24, 2026 04:46

xiaowei-guan added 7 commits February 24, 2026 20:47

Fix fail to render pixel buffer issue

ca30228

Add unit test

999ef41

Update unit test for rendering texture

8da1bb3

1.Make the texture red on the top half and blue on the botton half. 2.Add a new image file.

Code format

9195a8d

Add format check

55c900a

Only support GL_RGBA8 format now.

Trigger Build

d77c855

Trigger Build

2df7bd4

gaaclarke added this pull request to the merge queue Feb 24, 2026

Merged via the queue into flutter:master with commit 450478a Feb 24, 2026
183 checks passed

engine-flutter-autoroll mentioned this pull request Feb 25, 2026

Roll Flutter from dad6f9d4107a to b31548feb941 (39 revisions) flutter/packages#11116

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026

450478ad3 [Impeller] Fix fail to render pixel buffer texture on Linux (…

4b3008c

…flutter/flutter#181656)

engine-flutter-autoroll mentioned this pull request Feb 25, 2026

Roll Flutter from dad6f9d4107a to bcdd691f3b1a (40 revisions) flutter/packages#11117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026

450478ad3 [Impeller] Fix fail to render pixel buffer texture on Linux (…

f685af4

…flutter/flutter#181656)

engine-flutter-autoroll mentioned this pull request Feb 25, 2026

Roll Flutter from dad6f9d4107a to 26c4cd4e4a06 (41 revisions) flutter/packages#11119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2026

450478ad3 [Impeller] Fix fail to render pixel buffer texture on Linux (…

b823eab

…flutter/flutter#181656)

engine-flutter-autoroll mentioned this pull request Feb 26, 2026

Roll Flutter from dad6f9d4107a to b7ac273fa060 (69 revisions) flutter/packages#11126

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2026

450478ad3 [Impeller] Fix fail to render pixel buffer texture on Linux (…

8ef9015

…flutter/flutter#181656)

engine-flutter-autoroll mentioned this pull request Feb 26, 2026

Roll Flutter from dad6f9d4107a to b7ac273fa060 (69 revisions) flutter/packages#11132

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2026

450478ad3 [Impeller] Fix fail to render pixel buffer texture on Linux (…

ac9cabc

…flutter/flutter#181656)

Piinks mentioned this pull request Feb 28, 2026

Flutter Notable Commits - 2026 #181433

Open

xiaowei-guan mentioned this pull request Mar 3, 2026

RTCVideoView runs normally on macOS, but it reports errors when running on Windows, seemingly related to impeller flutter-webrtc/flutter-webrtc#1870

Open

xiaowei-guan deleted the linux_texture branch March 23, 2026 04:49

Conversation

xiaowei-guan commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard Bot commented Jan 29, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

xiaowei-guan commented Feb 3, 2026

Uh oh!

loic-sharma commented Feb 4, 2026

Uh oh!

xiaowei-guan commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

jason-simmons left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Feb 11, 2026

Uh oh!

xiaowei-guan commented Feb 12, 2026

Uh oh!

fluttergithubbot commented Feb 12, 2026

Uh oh!

gaaclarke commented Feb 12, 2026

Uh oh!

gaaclarke commented Feb 12, 2026

Uh oh!

auto-submit Bot commented Feb 12, 2026

Uh oh!

auto-submit Bot commented Feb 12, 2026

Uh oh!

xiaowei-guan commented Feb 24, 2026

Uh oh!

gaaclarke commented Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

xiaowei-guan commented Jan 29, 2026 •

edited

Loading

xiaowei-guan commented Feb 9, 2026 •

edited

Loading